Re: [Patch] Index as collapsable

2007-10-03 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Do people put umlauts in labels? Just filter them out I'd say. I think we already so. Jürgen

Re: [Patch] Index as collapsable

2007-10-03 Thread Martin Vermeer
On Wed, Oct 03, 2007 at 07:14:56PM +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > > Do we need to escape? I remeber seeing unescaped underscores in labels. > > I think we need to escape special characters (such as umlauts) in some > encodings. > > Jürgen Do people put umlauts in

Re: [Patch] Index as collapsable

2007-10-03 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Do we need to escape? I remeber seeing unescaped underscores in labels. I think we need to escape special characters (such as umlauts) in some encodings. Jürgen

Re: [Patch] Index as collapsable

2007-10-03 Thread Martin Vermeer
On Wed, Oct 03, 2007 at 05:56:47PM +0200, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > > Are the contents of labels general LaTeX text? I don't believe so. > > I don't think so. The only thing we have to care about is some escaping > things. But I think for labels, the current dialog a

Re: [Patch] Index as collapsable

2007-10-03 Thread Richard Heck
Juergen Spitzmueller wrote: Richard Heck wrote: There's a URL charstyle (duck!) in 1.6.svn, as url.module. So that's already been done. Does it have a dialog the enter the "Name" and select "html" (or whatever we had in the old dialog)? No, the charstyle is just for URL. The old URL

Re: [Patch] Index as collapsable

2007-10-03 Thread Juergen Spitzmueller
Richard Heck wrote: > There's a URL charstyle (duck!) in 1.6.svn, as url.module. So that's > already been done. Does it habe a dialog the enter the "Name" and select "html" (or whatever we had in the old dialog)? Jürgen

Re: [Patch] Index as collapsable

2007-10-03 Thread Richard Heck
Juergen Spitzmueller wrote: Martin Vermeer wrote Are the contents of labels general LaTeX text? I don't believe so. I don't think so. The only thing we have to care about is some escaping things. But I think for labels, the current dialog approach might be better. But URL! There's a UR

Re: [Patch] Index as collapsable

2007-10-03 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Are the contents of labels general LaTeX text? I don't believe so. I don't think so. The only thing we have to care about is some escaping things. But I think for labels, the current dialog approach might be better. But URL! Jürgen

Re: [Patch] Index as collapsable

2007-10-03 Thread Martin Vermeer
On Wed, 03 Oct 2007 15:56:03 +0200 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > On Wed, 03 Oct 2007 14:34:23 +0200 > > Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > > > >> Jean-Marc Lasgouttes wrote: > >>> Martin Vermeer <[EMAIL PROTECTED]> writes: > >>> > On Wed

Re: [Patch] Index as collapsable

2007-10-03 Thread Abdelrazak Younes
Martin Vermeer wrote: On Wed, 03 Oct 2007 14:34:23 +0200 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Jean-Marc Lasgouttes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: On Wed, 03 Oct 2007 12:07:26 +0200 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: Martin Vermeer <[EMAIL PROTECTED]>

Re: [Patch] Index as collapsable

2007-10-03 Thread Martin Vermeer
On Wed, 03 Oct 2007 14:34:23 +0200 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Jean-Marc Lasgouttes wrote: > > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > >> On Wed, 03 Oct 2007 12:07:26 +0200 > >> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > >> > >>> Martin Vermeer <[EMAIL PROTECTED

Re: [Patch] Index as collapsable

2007-10-03 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: On Wed, 03 Oct 2007 12:07:26 +0200 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: The attached contains everything including the lyx2lyx stuff. Looks good. The only think I do

Re: [Patch] Index as collapsable

2007-10-03 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > On Wed, 03 Oct 2007 12:07:26 +0200 > Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> > The attached contains everything including the lyx2lyx stuff. >> >> Looks good. The only think I do no like mu

Re: [Patch] Index as collapsable

2007-10-03 Thread Martin Vermeer
On Wed, 03 Oct 2007 12:07:26 +0200 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > The attached contains everything including the lyx2lyx stuff. > > Looks good. The only think I do no like much is the explicit test > against LFUN_INDEX_INSERT. B

Re: [Patch] Index as collapsable

2007-10-03 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > The attached contains everything including the lyx2lyx stuff. Looks good. The only think I do no like much is the explicit test against LFUN_INDEX_INSERT. But this is a small issue. JMarc

[Patch] Index as collapsable

2007-10-03 Thread Martin Vermeer
The attached contains everything including the lyx2lyx stuff. OK to commit? - Martin Index: src/insets/InsetIndex.cpp === --- src/insets/InsetIndex.cpp (revision 20607) +++ src/insets/InsetIndex.cpp (working copy) @@ -27,41 +27,75 @