Re: [Patch] Improving the Citation GUI.

2010-10-22 Thread John McCabe-Dansted
This patch got buried when I was distracted by my thesis. Apologies for the delay. I address the comments to the previous patch. Notes: 1) The potential security issue has been addressed by only using LyX's viewers. 2) Richard suggested that I regenerate the filename/url on demand, I discuss why

Re: [Patch] Improving the Citation GUI.

2010-03-24 Thread rgheck
On 03/24/2010 03:05 PM, Charles de Miramon wrote: rgheck wrote: Feel free to grab Qt Designer and work on this. Or at least produce a mock-up. I found the CitationUi.ui file and opened it in Qt Designer. But before playing with it, I was wondering about the possibility to have mult

Re: [Patch] Improving the Citation GUI.

2010-03-24 Thread Charles de Miramon
rgheck wrote: > Feel free to grab Qt Designer and work on this. Or at least produce a > mock-up. > I found the CitationUi.ui file and opened it in Qt Designer. But before playing with it, I was wondering about the possibility to have multiple Citations. The only use case is, if I unders

Re: [Patch] Improving the Citation GUI.

2010-03-24 Thread rgheck
On 03/23/2010 02:33 PM, Charles de Miramon wrote: I think the dialog would be simpler to use if it had a more classical look like Endnote X2 insertion dialog : Feel free to grab Qt Designer and work on this. Or at least produce a mock-up. rh

Re: [Patch] Improving the Citation GUI.

2010-03-24 Thread rgheck
On 03/23/2010 02:33 PM, Charles de Miramon wrote: I would suppress from LyX dialog the option enabling Search-as-you-type. For me it seems that having it the defaut is what is expected The difficulty is that this can be very slow if your BibTeX file is large: We have to search the whole th

Re: [Patch] Improving the Citation GUI.

2010-03-24 Thread rgheck
On 03/23/2010 12:17 PM, Pavel Sanda wrote: Richard Heck wrote: xdg-open should open different things depending upon the extension. Here, e.g., xdg-open file.tex opens kile. xdg-open knows nothing about extensions. it just passes the control to the desktop manager, i.e. it detect in a

RE: [Patch] Improving the Citation GUI.

2010-03-23 Thread Rob Oakes
riably spend an afternoon hunched over a reference thinking, "Did I ever learn how to use these?" -Original Message- From: Charles de Miramon [mailto:cmira...@nerim.net] Sent: Tuesday, March 23, 2010 12:34 PM To: lyx-devel@lists.lyx.org Subject: Re: [Patch] Improving the Citation

Re: [Patch] Improving the Citation GUI.

2010-03-23 Thread Charles de Miramon
John McCabe-Dansted wrote: > The attached patch resolved the following tickets: > #6486 Citation not selected by default. > #6487 Add "file" and "url" links to Citation Dialog. Thank you for #6486 I think the dialog would be simpler to use if it had a more classical look like Endnote X2 ins

Re: [Patch] Improving the Citation GUI.

2010-03-23 Thread Pavel Sanda
Richard Heck wrote: > xdg-open should open different things depending upon the extension. Here, > e.g., xdg-open file.tex opens kile. xdg-open knows nothing about extensions. it just passes the control to the desktop manager, i.e. it detect in a hackish style what dm you use and then sends the fi

Re: [Patch] Improving the Citation GUI.

2010-03-23 Thread rgheck
On 03/23/2010 10:41 AM, Pavel Sanda wrote: John McCabe-Dansted wrote: I could paste the patch into the email, but I don't think that is what you mean. Could you give an example of an email client that can do this? (I don't think the gmail webclient can). the patches from John look cor

Re: [Patch] Improving the Citation GUI.

2010-03-23 Thread Pavel Sanda
John McCabe-Dansted wrote: > I could paste the patch into the email, but I don't think that is what > you mean. Could you give an example of an email client that can do > this? (I don't think the gmail webclient can). the patches from John look correct here (mutt). > > +// Tells OS to open a File

Re: [Patch] Improving the Citation GUI.

2010-03-23 Thread rgheck
On 03/23/2010 05:52 AM, John McCabe-Dansted wrote: On Tue, Mar 23, 2010 at 4:25 AM, rgheck wrote: On 03/22/2010 03:14 PM, John McCabe-Dansted wrote: The attached patch resolved the following tickets: #6486 Citation not selected by default. #6487 Add "file" and "url" links to Citation

Re: [Patch] Improving the Citation GUI.

2010-03-23 Thread John McCabe-Dansted
On Tue, Mar 23, 2010 at 4:25 AM, rgheck wrote: > On 03/22/2010 03:14 PM, John McCabe-Dansted wrote: > > The attached patch resolved the following tickets: > #6486 Citation not selected by default. > #6487 Add "file" and "url" links to Citation Dialog. ... > Please try to attach the patch in su

Re: [Patch] Improving the Citation GUI.

2010-03-22 Thread rgheck
On 03/22/2010 03:14 PM, John McCabe-Dansted wrote: The attached patch resolved the following tickets: #6486 Citation not selected by default. #6487 Add "file" and "url" links to Citation Dialog. Please try to attach the patch in such a way that it'll show up in the email and as an att

[Patch] Improving the Citation GUI.

2010-03-22 Thread John McCabe-Dansted
The attached patch resolved the following tickets: #6486 Citation not selected by default. #6487 Add "file" and "url" links to Citation Dialog. This means that if you are reading you see something like "As proved by [ABC09] 1+1=3" you can double click the ABC09 and immediately get the citation