Re: [Patch] Gtk Document dialog

2005-03-11 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | John Spray wrote: >> It appears that the backend passes a "one|two|three" type string, which >> is then parsed by the frontend (since only xforms takes that kind of >> string for a combo natively), put into the combobox, and the same >> user-visible stri

Re: [Patch] Gtk Document dialog

2005-03-11 Thread Angus Leeming
John Spray wrote: > It appears that the backend passes a "one|two|three" type string, which > is then parsed by the frontend (since only xforms takes that kind of > string for a combo natively), put into the combobox, and the same > user-visible strings are passed back. > > 1. Shouldn't the backe

Re: [Patch] Gtk Document dialog

2005-03-11 Thread John Spray
On Fri, 2005-03-11 at 10:28, Jean-Marc Lasgouttes wrote: > Concerning the font sizes: the 10|11|12 value is only the default for > basic classes, and I am not sure actually why the xforms and qt > frontends use it. Later in the code, they initialize the combox with > the value of LyXTextClass::opt_

Re: [Patch] Gtk Document dialog

2005-03-11 Thread Jean-Marc Lasgouttes
> "John" == John Spray <[EMAIL PROTECTED]> writes: John> Revised patch attached. Concerning the font sizes: the 10|11|12 value is only the default for basic classes, and I am not sure actually why the xforms and qt frontends use it. Later in the code, they initialize the combox with the value

Re: [Patch] Gtk Document dialog

2005-03-10 Thread John Spray
On Fri, 2005-03-11 at 00:55 +0100, Lars Gullik Bjønnes wrote: > Ooo space after ',' missing. > Drop the bool const and use only bool here. On declarations: not const > on pods, in definitions it is ok. > defunit cannot be a const ref? > ditto 'bool const' -> 'bool' Thanks Lars, all suggested

Re: [Patch] Gtk Document dialog

2005-03-10 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Index: GDocument.C | === | RCS file: GDocument.C | diff -N GDocument.C | --- /dev/null 1 Jan 1970 00:00:00 - | +++ GDocument.C 10 Mar 2005 21:33:26 - | @@ -0,0 +1,289 @@ | +/** |

Re: [Patch] Gtk Document dialog

2005-03-10 Thread Angus Leeming
John Spray wrote: > Hi, > > This patch delivers the first page of the gtk document dialog. I'm > submitting this now rather than finishing the whole dialog in the > interests of getting incremental feedback. This is a somewhat swollen > patch, since it also includes some new stuff in ghelpers,