Re: [Patch] GWorkArea buttonpress handling

2004-11-04 Thread John Spray
On Thu, 2004-11-04 at 21:37 +0100, Lars Gullik Bjønnes wrote: > Why not a freestanding function? Should be no need to have this in > GWorkArea? > until used in other places as well, just put it in anon namespace in > GWorkArea.C. Done and committed. John

Re: [Patch] GWorkArea buttonpress handling

2004-11-04 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Hi, > | When writing the box dialog, I noticed that all mouse clicks were having | the button-1 effect. This was because the gdk mouse button integer was | being cast straight to a mouse_button::state, so 1 converted correctly | but other values didn't. P

[Patch] GWorkArea buttonpress handling

2004-11-04 Thread John Spray
Hi, When writing the box dialog, I noticed that all mouse clicks were having the button-1 effect. This was because the gdk mouse button integer was being cast straight to a mouse_button::state, so 1 converted correctly but other values didn't. Patch attached. John Index: GWorkArea.C ===