Re: [Patch] Fix bug 3970: Include file crash

2007-07-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> So I maintain that this is the right fix. OK. JMarc

Re: [Patch] Fix bug 3970: Include file crash

2007-07-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: No, we don't display it but we make it ready for display: - update the labels (child and master) - update the toc backend (child and master) - update the View menu - update the tabbar. I see. If so, this is wrong for fillWithBibKeys, and we

Re: [Patch] Fix bug 3970: Include file crash

2007-07-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > No, we don't display it but we make it ready for display: > - update the labels (child and master) > - update the toc backend (child and master) > - update the View menu > - update the tabbar. I see. > > If so, this is wrong for fillWithBibKeys, and > > we need again a

Re: [Patch] Fix bug 3970: Include file crash

2007-07-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > This code dates from 2003 (rev 7797) so it was always loaded. What is > different is that we now always pass through LyXView to load a LyX file > while previously the file were only loaded in the background. Does that mean that we used to open the buffer without actually

Re: [Patch] Fix bug 3970: Include file crash

2007-07-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: Just wait a bit. Juergen, I thought we were no supposed to load child documents just for the pleasure of displaying bibkeys. I seem to remember fixes in this area some time ago. Do you remember? Yes. The child documents should not be loaded

Re: [Patch] Fix bug 3970: Include file crash

2007-07-04 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Just wait a bit. Juergen, I thought we were no supposed to load child > documents just for the pleasure of displaying bibkeys. I seem to > remember fixes in this area some time ago. Do you remember? Yes. The child documents should not be loaded for this IIRC. If they

Re: [Patch] Fix bug 3970: Include file crash

2007-07-04 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> It was not very easy to find but the fix is simple and is Abdelrazak> obvious once found. The problem is that a screen update Abdelrazak> needs a bibtex key for proper rendering of the Citation. Abdelrazak> This key re

[Patch] Fix bug 3970: Include file crash

2007-07-04 Thread Abdelrazak Younes
It was not very easy to find but the fix is simple and is obvious once found. The problem is that a screen update needs a bibtex key for proper rendering of the Citation. This key requires the master document to load all child document, which trigger an additional screen update, even when we do