Re: [Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Pavel Sanda
> Or output to a string (or ostringstream) first and then use rstrip. > But it may be that this will not do encoding properly. What encoding > does hyperref want in its title things? afaiu there is possibility to switch between PDFDocEncoding and unicode. i played a bit with setting enc. to utf8

Re: [Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: >> I expect people will think this is at best ugly. I guess I'd do it by >> outputting the comma BEFORE each bit...but only after testing some flag > > you cant after, there's no way back :) Or output to a string (or ostringstream) first and then use rstr

Re: [Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Richard Heck
Pavel Sanda wrote: I expect people will think this is at best ugly. I guess I'd do it by outputting the comma BEFORE each bit...but only after testing some flag you cant after, there's no way back :) that tells us whether we've done the first one yet. i was thinking about impl

Re: [Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Pavel Sanda
> I expect people will think this is at best ugly. I guess I'd do it by > outputting the comma BEFORE each bit...but only after testing some flag you cant after, there's no way back :) > that tells us whether we've done the first one yet. i was thinking about implementing some stream in-betwee

Re: [Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > It might help make the code a little clearer if all of this stuff were > taken out into a PDFOptions::writeLatex(odocstream &) routine that > could just be called directly here, without even checking > use_hyperref. You could do that there. And then chang

Re: [Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Richard Heck
Comments below. diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp index e566cdd..2d297e2 100644 --- a/src/BufferParams.cpp +++ b/src/BufferParams.cpp @@ -1123,6 +1171,52 @@ bool BufferParams::writeLaTeX(odocstream & os, LaTeXFeatures & features, + from_utf8(preambl

[Patch#2] Bug 3527 - Basic PDF support via hyperref

2007-09-13 Thread Pavel Sanda
hi, this is iteration #2. i guess that #3 will be needed still :) any comments to code welcomed. i have tested it on the few cases i usually use and seems to work. sum of TODOS & screenshot added to wiki: http://wiki.lyx.org/Devel/PDFSupport TODOs & (my) questions - does the ending ',' in \usep