Re: [PATCHes] do not open collapsable insets when selecting

2006-12-20 Thread Enrico Forestieri
On Wed, Dec 20, 2006 at 02:27:08PM +0100, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> I fear that you exchanged an annoyance with a crash... > > I swear that I originally planned to test the 1.5 patch before > committing it! Venia dig

Re: crash due to: [PATCHes] do not open collapsable insets when selecting

2006-12-20 Thread Jean-Marc Lasgouttes
> "Uwe" == Uwe Stöhr <[EMAIL PROTECTED]> writes: Uwe> JMarc wrote: >> When selecting a collapsable inset with the mouse, it opens at >> mouse release time. This is very very annoying... >> The following pair of patches fix this. Objections? Uwe> I applied your changes in revision 16337 and t

Re: [PATCHes] do not open collapsable insets when selecting

2006-12-20 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> I fear that you exchanged an annoyance with a crash... I swear that I originally planned to test the 1.5 patch before committing it! It should work now. JMarc Index: src/insets/insetcollapsable.C ==

crash due to: [PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Uwe Stöhr
JMarc wrote: > When selecting a collapsable inset with the mouse, it opens at mouse > release time. This is very very annoying... > The following pair of patches fix this. Objections? I applied your changes in revision 16337 and this introduces a crash. - highlight text together with an inset

Re: [PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Enrico Forestieri
On Tue, Dec 19, 2006 at 02:50:46PM +0100, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> Abdelrazak Younes wrote: > >> Jean-Marc Lasgouttes wrote: > >>> When selecting a collapsable inset with the mouse, it opens at > >>> mouse rel

Re: [PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak> I think I misread the patch and that my understanding Abdelrazak> above was wrong. In that case, please forget my objection. Yes, I think you got it wrong. What the patch changes is what happens on mouse1 release. Normally it is 'toggle the inset', the pat

Re: [PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Abdelrazak Younes wrote: >> Jean-Marc Lasgouttes wrote: >>> When selecting a collapsable inset with the mouse, it opens at >>> mouse release time. This is very very annoying... >> Why is that annoying? >> >>> The fo

Re: [PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: When selecting a collapsable inset with the mouse, it opens at mouse release time. This is very very annoying... Why is that annoying? The following pair of patches fix this. Objections? Yes. I would imagine that "mouse click on inset"

Re: [PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: When selecting a collapsable inset with the mouse, it opens at mouse release time. This is very very annoying... Why is that annoying? The following pair of patches fix this. Objections? Yes. I would imagine that "mouse click on inset" should be reserved for dr

[PATCHes] do not open collapsable insets when selecting

2006-12-19 Thread Jean-Marc Lasgouttes
When selecting a collapsable inset with the mouse, it opens at mouse release time. This is very very annoying... The following pair of patches fix this. Objections? JMarc Index: src/insets/insetcollapsable.C === --- src/insets/inse