Re: [PATCH 4263] Listing support for erlang.

2007-10-13 Thread Bo Peng
On 10/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: > Bo Peng wrote: > > I can not test here because my listings is too old. Can anyone test > > the attached? (This time, with QListings and status.15x). > > I tested and it works fine. Please commit. Done. Bo

Re: [PATCH 4263] Listing support for erlang.

2007-10-13 Thread Jürgen Spitzmüller
Bo Peng wrote: > I can not test here because my listings is too old. Can anyone test > the attached? (This time, with QListings and status.15x). I tested and it works fine. Please commit. Jürgen

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Andre Poenitz
On Wed, Oct 10, 2007 at 12:10:53PM +0200, Jean-Marc Lasgouttes wrote: > Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > > > Jean-Marc Lasgouttes wrote: > > > >> Why is erlang lowercase? Is that what listings does? > > > > Yes. > > It is weird to do it for only one language... It is not, is it

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Bo Peng
> This is no file format change, right? So people with 1.5.2 and earlier are > able to open a file with this language? This is not a problem. When an unknown language is given, the language combo box is disabled, and the whole option is moved to the advanced tab. The lyx file can still compile. >

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > It is weird to do it for only one language... There are also other languages that are lowercase. However, the parsing of the language and dialect arguments is case insensitive, according to the listings docs. Jürgen

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Jean-Marc Lasgouttes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes wrote: > >> Why is erlang lowercase? Is that what listings does? > > Yes. It is weird to do it for only one language... JMarc

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Why is erlang lowercase? Is that what listings does? Yes. Note, however, that also languages[] and languages_gui[] in qt4/QListings.cpp need to be adapted (in the latter, we should use Uppercase). Jürgen

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: > +++ src/insets/InsetListingsParams.cpp(working copy) > @@ -246,7 +246,7 @@ > "[Sharp]C\nC++\n[ANSI]C++\n[GNU]C++\n[ISO]C++\n[Visual]C++\nCaml\n" > "[light]Caml\n[Objective]Caml\nClean\nCobol\n[1974]Cobol\n[1985]Cobol\n" > "[ibm]Cobo

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Juergen Spitzmueller
Bo Peng wrote: > This is trivial. Trunk and branch? This is no file format change, right? So people with 1.5.2 and earlier are able to open a file with this language? If so, go ahead. Jürgen

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread Abdelrazak Younes
José Matos wrote: On Wednesday 10 October 2007 04:24:59 Bo Peng wrote: This is trivial. Trunk and branch? For trunk yes, but as you know it would be nice to have this information in an external file. :-) Agreed. Haven't we seen a patch from Bo that does that actually? Abdel.

Re: [PATCH 4263] Listing support for erlang.

2007-10-10 Thread José Matos
On Wednesday 10 October 2007 04:24:59 Bo Peng wrote: > This is trivial. Trunk and branch? For trunk yes, but as you know it would be nice to have this information in an external file. :-) > Bo -- José Abílio

[PATCH 4263] Listing support for erlang.

2007-10-09 Thread Bo Peng
+++ src/insets/InsetListingsParams.cpp (working copy) @@ -246,7 +246,7 @@ "[Sharp]C\nC++\n[ANSI]C++\n[GNU]C++\n[ISO]C++\n[Visual]C++\nCaml\n" "[light]Caml\n[Objective]Caml\nClean\nCobol\n[1974]Cobol\n[1985]Cobol\n" "[ibm]Cobol\nComal 80\ncommand.com\n[WinXP]command.com\nCom