Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Bo Peng
> And so you decied to add it, right? ;) > > Go ahead and commit. Done. Thanks. Remember to fix middle-button-paste. :-) Bo

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> Here is the deal: you can rename the button if you make sure with Uwe >> that the relevant manual is updated. Is that fair? > > I briefly checked the menu, and found no document for this 'load' button. :-) And so you decied to add it, right? ;) Go ahead a

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Bo Peng
> Here is the deal: you can rename the button if you make sure with Uwe > that the relevant manual is updated. Is that fair? I briefly checked the menu, and found no document for this 'load' button. :-) Bo

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: > Can I apply the attached patch to the branch? If you do not like the > name change (Load->Edit) because of translation, documentation etc, I > can fix the crash in branch, and apply the full patch to trunk. Here is the deal: you can rename the button if you

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Bo Peng
> > Did you test it? If so, I need another OK to proceed. > > > It seems to work here, yes. JMarc, Can I apply the attached patch to the branch? If you do not like the name change (Load->Edit) because of translation, documentation etc, I can fix the crash in branch, and apply the full patch to tr

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Richard Heck
Bo Peng wrote: The patch looks obvious. Did you test it? If so, I need another OK to proceed. It seems to work here, yes. rh -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ =

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Bo Peng
> The patch looks obvious. Did you test it? If so, I need another OK to proceed. > > > I'd agree but don't care a lot either way. I will change to Edit because 'Load' only makes sense for .lyx file. Cheers, Bo

Re: [PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-07 Thread Richard Heck
Bo Peng wrote: Symptom: inset a child document in type include, select a .tex file with relative path, load. Lyx crashes. Problem: In formats.edit(... Filename(file), "text"), file needs to be a full path name. Patch: The attached simple patch fixes this. It may also have fixed bug 4107. No

[PATCH 4111] load .tex child document in relative path crashes lyx.

2007-08-06 Thread Bo Peng
Symptom: inset a child document in type include, select a .tex file with relative path, load. Lyx crashes. Problem: In formats.edit(... Filename(file), "text"), file needs to be a full path name. Patch: The attached simple patch fixes this. It may also have fixed bug 4107. Note that this file