Re: [PATCH-updated] Bug 3478

2007-04-23 Thread Richard Heck
Committed this version. Bernhard Roider wrote: > there is an error in the previous patch. of course i would suggest > this one. > > bernhard > > > Index: insetbibtex.C > ==

Re: [PATCH-updated] Bug 3478

2007-04-22 Thread Richard Heck
I'll look at this later and give it a test, then commit if it's OK. rh Bernhard Roider wrote: > there is an error in the previous patch. of course i would suggest > this one. > > bernhard > > > Index: insetbibtex.C > ==

Re: [PATCH-updated] Bug 3478

2007-04-21 Thread Bernhard Roider
there is an error in the previous patch. of course i would suggest this one. bernhard Index: insetbibtex.C === --- insetbibtex.C (revision 17723) +++ insetbibtex.C (working copy) @@ -373,13 +373,20 @@ return true; } + + enum c

Re: [PATCH-updated] Bug 3478

2007-04-21 Thread Bernhard Roider
Hello, i failed to test the parser with older lyx documents... I would suggest not to use the two functions readKey and readType because then readType is used to read a key of a string entry - which makes the code harder to read. I would suppose the attached patch. Bernhard Richard Heck wro

[PATCH-updated] Bug 3478

2007-04-19 Thread Richard Heck
Bernhard, Do you want to comment on this? Have a look especially at the bits about entryDelim. At first, I thought I'd caught a typo---"{" getting paired with ")"---but then I realized that entryDelim never actually got used. So I think it can just be removed, as in the diff. Otherwise, I think t