Re: [PATCH] updateMacros() does not descend into tables

2010-10-20 Thread Jean-Marc Lasgouttes
Le 20/10/2010 00:15, Richard Heck a écrit : It looks like you could push_back the slice outside of the for loop. I tried something like that, but it seems not to see the cells when you go back through. Finally, this cries for a Inset::updateMacros virtual method allowing to move this stuff wh

Re: [PATCH] updateMacros() does not descend into tables

2010-10-19 Thread Richard Heck
On 10/19/2010 05:45 PM, Jean-Marc Lasgouttes wrote: Le 17 oct. 10 à 21:56, Richard Heck a écrit : Can someone who actually understands that stuff have a look at the attached and tell me if it is OK? If you tested that it works as expected, it is probably OK. A remark on the code: + +

Re: [PATCH] updateMacros() does not descend into tables

2010-10-19 Thread Jean-Marc Lasgouttes
Le 17 oct. 10 à 21:56, Richard Heck a écrit : Can someone who actually understands that stuff have a look at the attached and tell me if it is OK? If you tested that it works as expected, it is probably OK. A remark on the code: + + if (iit->inset

[PATCH] updateMacros() does not descend into tables

2010-10-17 Thread Richard Heck
Can someone who actually understands that stuff have a look at the attached and tell me if it is OK? Thanks, Richard Index: src/Buffer.cpp === --- src/Buffer.cpp (revision 35669) +++ src/Buffer.cpp (working copy) @@ -70