Re: [PATCH] unify/fix some cursor moving routines.

2006-07-14 Thread Abdelrazak Younes
Andre Poenitz wrote: On Thu, Jul 13, 2006 at 03:56:02PM +0200, Abdelrazak Younes wrote: Georg Baum wrote: Abdelrazak Younes wrote: As a side note, I really think the coordcache concept is flawed. Well, I guess should be a bit more diplomatic in my words. I meant that the way the coordCache i

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-14 Thread Andre Poenitz
On Thu, Jul 13, 2006 at 03:56:02PM +0200, Abdelrazak Younes wrote: > Georg Baum wrote: > >Abdelrazak Younes wrote: > > > >>As a side note, I really think the coordcache concept is flawed. > > Well, I guess should be a bit more diplomatic in my words. I meant that > the way the coordCache is used

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Abdelrazak Younes
Georg Baum wrote: Abdelrazak Younes wrote: As a side note, I really think the coordcache concept is flawed. Well, I guess should be a bit more diplomatic in my words. I meant that the way the coordCache is used is flawed. What is problematic is it's use all other the place in LyXCode withou

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Bo Peng
Bo> Forget about configure, try scons now. :-) I do not think scons is immune to such errors. Well, there is no configure step in scons (it configures each time) so if you get a correct build, it is correct, unless you use tricks like rebuild=components, in which cases other components are not

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> No, I am not saying that. I was just clarifying the Abdelrazak> matter. I think there are two solutions: Abdelrazak> 1) make sure that the coordCache is up to date at the end Abdelrazak> of an

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Georg Baum
Abdelrazak Younes wrote: > As a side note, I really think the coordcache concept is flawed. IIRC it was introduced as part of the two-step drawing scheme that helped to get rid of lots of hacks that were present in 1.3. If it is not properly documented somewhere please get Andre to write a short

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> No, I am not saying that. I was just clarifying the Abdelrazak> matter. I think there are two solutions: Abdelrazak> 1) make sure that the coordCache is up to date at the end Abdelrazak> of any user action. This was p

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Maybe, but I don't think this is related to this Abdelrazak> re-ordering in that particular case. FYI, it's Lars that Abdelrazak> changed the calls to updateMetrics, not me. I have to admit

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Maybe, but I don't think this is related to this Abdelrazak> re-ordering in that particular case. FYI, it's Lars that Abdelrazak> changed the calls to updateMetrics, not me. I have to admit that I did not follow the

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdel, I suspect it is related to your changes. Abdelrazak> Could be but not certain. I'll investigate. Abdelrazak> As a side note, I really think the coordcache concept is Abdelrazak> flawed. Or mayb

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdel, I suspect it is related to your changes. Abdelrazak> Could be but not certain. I'll investigate. Abdelrazak> As a side note, I really think the coordcache concept is Abdelrazak> flawed. Or maybe your reordering of how

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: There is a crash on trunk, but I check it is unrelated to the patch: Yes, and another one 1/ Help>User Guide 2/ Enter the note inset with the arrow cursor 3/ go out the inset with the down arrow cursor 1/ Help>Introduction 2/ Shift-PageDown 3/ crash! Assertion

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: OK. Since we have our 3rd tester Juergen> now, I'll propose that you shove your fix into branch and Juergen> trunk then. >> This is done now. Juergen> Thanks. BTW the crash was bug 2683. Oop

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> OK. Since we have our 3rd tester now, I'll propose that you > Juergen> shove your fix into branch and trunk then. > > This is done now. Thanks. BTW the crash was bug 2683. Jürgen

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-13 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> I just noticed that I did not reconfigure using frontend=qt3. This >> means that make did not really rebuild lyx :) Juergen> I'm glad to hear that even you make such errors. >> I'll report

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: Bo> On 7/12/06, Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: >> Jean-Marc Lasgouttes wrote: > I just noticed that I did not >> reconfigure using frontend=qt3. This > means that make did not >> really rebuild lyx :) >> >> I'm glad to hear that e

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Bo Peng
On 7/12/06, Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: Jean-Marc Lasgouttes wrote: > I just noticed that I did not reconfigure using frontend=qt3. This > means that make did not really rebuild lyx :) I'm glad to hear that even you make such errors. Forget about configure, try scons now. :

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I just noticed that I did not reconfigure using frontend=qt3. This > means that make did not really rebuild lyx :) I'm glad to hear that even you make such errors. > I'll report tomorrow. OK. Since we have our 3rd tester now, I'll propose that you shove your fix

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> No, I checked with a new user directory. What I do is load the >> Introduction help file, click somewhere and then use >> Shift-PageDown. This does not start a selection. Juergen> That's wh

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > No, I checked with a new user directory. What I do is load the > Introduction help file, click somewhere and then use Shift-PageDown. > This does not start a selection. That's what I did as well, and it works for me. I guess we are talking about the same function (sc

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> This is the 1.5 port of the patch discussed with Juergen. >> Unfortunately, shift-pagedown does not begin a selection, and I do >> not see why. Juergen? Juergen> It works for me. Perhaps yo

Re: [PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > This is the 1.5 port of the patch discussed with Juergen. > Unfortunately, shift-pagedown does not begin a selection, and I do not > see why. Juergen? It works for me. Perhaps you have a binding file conflict? Jürgen

[PATCH] unify/fix some cursor moving routines.

2006-07-12 Thread Jean-Marc Lasgouttes
This is the 1.5 port of the patch discussed with Juergen. Unfortunately, shift-pagedown does not begin a selection, and I do not see why. Juergen? JMarc Index: src/text3.C === --- src/text3.C (revision 14419) +++ src/text3.C (workin