Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-09-01 Thread Andre Poenitz
On Thu, Aug 31, 2006 at 10:18:59AM +0200, Abdelrazak Younes wrote: > >| - char out[1000] = { 0 }; > >| + static char out[1000]; > > > >Did you see if you get the same speedup if you just disable the > >initialization "{ 0 };"? > > No I didn't try. You reckon that the compiler will optimize that

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-31 Thread Angus Leeming
Lars Gullik Bjønnes wrote: Angus Leeming writes: | Lars Gullik Bjønnes wrote: | > | What's that? "No, I have an objection" or "No objection." ? | > d/,/ | | You're inventing syntax ;-) | | Either you mean 's/,//' or you mean '/,/d', this latter removing the | entire line. sod sed. tr -d ','

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-31 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > | What's that? "No, I have an objection" or "No objection." ? | > d/,/ | | You're inventing syntax ;-) | | Either you mean 's/,//' or you mean '/,/d', this latter removing the | entire line. sod sed. tr -d ',' --

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-31 Thread Angus Leeming
Lars Gullik Bjønnes wrote: | What's that? "No, I have an objection" or "No objection." ? d/,/ You're inventing syntax ;-) Either you mean 's/,//' or you mean '/,/d', this latter removing the entire line. Pedantically yrs, Angus

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-31 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Abdel. | > | Index: unicode.C | > | === | > | --- unicode.C (revision 14849) | > | +++ unicode.C (working copy) | > | @@ -49,7 +49,7 @@ | > | |

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-31 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | This simple patch provides a nice speedup without any visual side | > effect. | > | | Comments? Objection? | > No, objections. | | What's that? "No, I have an objecti

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-31 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This simple patch provides a nice speedup without any visual side effect. | | Comments? Objection? No, objections. What's that? "No, I have an objection" or "No objection." ? | Abdel. | Index: unicode.C | ===

Re: [PATCH] unicode::iconv_convert() simple optimisation

2006-08-30 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This simple patch provides a nice speedup without any visual side effect. | | Comments? Objection? No, objections. | Abdel. | Index: unicode.C | === | --- unicode.C (revision 14849)

[PATCH] unicode::iconv_convert() simple optimisation

2006-08-30 Thread Abdelrazak Younes
This simple patch provides a nice speedup without any visual side effect. Comments? Objection? Abdel. Index: unicode.C === --- unicode.C (revision 14849) +++ unicode.C (working copy) @@ -49,7 +49,7 @@ char ICONV_CONST