Re: [PATCH] two fixes, broken

2001-12-07 Thread John Levon
On Fri, Dec 07, 2001 at 08:42:11PM +0200, Dekel Tsur wrote: > I've applied the patch with some changed. thank you. > I avoided the crash by not doing an update when the paragraph is inside an > inset. I've already had this problem in BufferView::ChangeInsets. I'm looking at what you did now.

Re: [PATCH] two fixes, broken

2001-12-07 Thread Dekel Tsur
On Tue, Dec 04, 2001 at 01:49:46AM +, John Levon wrote: > > please tell me what I need to fix with the attached. It is supposed to > fix : > > 1) errors should be inserted inside minipages etc., and converted to Standard > 2) all errors should be removed > > The first one works fine, except

Re: [PATCH] two fixes, broken (iterator questions)

2001-12-04 Thread Juergen Vigna
On 04-Dec-2001 John Levon wrote: >> >text->fullRebreak(this); >> Can someone explain to me why a full rebreak is performed after each >> error is removed? >> (The old code did this too... and also when the errors are inserted.) I >> would have thought that could wait until

Re: [PATCH] two fixes, broken (iterator questions)

2001-12-03 Thread John Levon
On Tue, Dec 04, 2001 at 01:07:52PM +1100, Ben Stanley wrote: > > text->redoParagraphs(this, cursor, > > cursor.par()->next()); > > text->fullRebreak(this); > > } > > > Can someone explain to me why a full

Re: [PATCH] two fixes, broken (iterator questions)

2001-12-03 Thread Ben Stanley
Some questions on iterators below... John Levon wrote: >+ if (par->autoDeleteInsets()) { >+ found = true; > text->redoParagraphs(this, cursor, >cursor.par()->next()); > text-

[PATCH] two fixes, broken

2001-12-03 Thread John Levon
please tell me what I need to fix with the attached. It is supposed to fix : 1) errors should be inserted inside minipages etc., and converted to Standard 2) all errors should be removed The first one works fine, except there is a need to do a proper update (as the size changed), and I don't kn