Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-28 Thread André Pönitz
On Sun, Oct 28, 2012 at 01:46:05PM +0100, Stephan Witt wrote: > >> Can you point me to the rules for coding style please? > > > > I only know of the old files in development/coding. > > The best match I found is: > > - Adapt the formatting of your code to the one used in the >other parts of

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-28 Thread Lars Gullik Bjønnes
Stephan Witt writes: | Am 27.10.2012 um 22:21 schrieb Lars Gullik Bjønnes : > >> On 27 October 2012 21:31, Stephan Witt wrote: >>> Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : >>> > This invalidates all patches hanging around for cosmetic reasons. > Is this really necessary? >>>

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-28 Thread Stephan Witt
Am 27.10.2012 um 22:21 schrieb Lars Gullik Bjønnes : > On 27 October 2012 21:31, Stephan Witt wrote: >> Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : >> This invalidates all patches hanging around for cosmetic reasons. Is this really necessary? >>> >>> Why do you have patches h

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Abdelrazak Younes
Hi Stephan, On 27/10/2012 20:56, Stephan Witt wrote: This invalidates all patches hanging around for cosmetic reasons. Is this really necessary? Stephan Coding style and consistency is always worth it IMO. Solving merge issues because of those are often easy. But this was a very valid questi

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Abdelrazak Younes
Hi Lars, I didn't read in detail but I think this patch is good. Thanks, Abdel

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
On 27 October 2012 21:31, Stephan Witt wrote: > Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : > >>> This invalidates all patches hanging around for cosmetic reasons. >>> Is this really necessary? >> >> Why do you have patches hanging around? > > Because I didn't apply them? Commit them to

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Stephan Witt
Am 27.10.2012 um 21:12 schrieb Lars Gullik Bjønnes : >> This invalidates all patches hanging around for cosmetic reasons. >> Is this really necessary? > > Why do you have patches hanging around? Because I didn't apply them? > Are you saying that changes are hostage to undisclosed patches that >

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
Stephan Witt writes: | Am 27.10.2012 um 15:46 schrieb Lars Gullik Bjønnes : > >> --- >> src/AppleSpellChecker.cpp | 6 +- >> src/AspellChecker.cpp | 32 +++-- >> src/Author.cpp| 13 +- >> src/BiblioInfo.cpp| 233 +- >> src/Bidi.cpp

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Lars Gullik Bjønnes
> This invalidates all patches hanging around for cosmetic reasons. > Is this really necessary? Why do you have patches hanging around? Are you saying that changes are hostage to undisclosed patches that someone might have? And if it takes you more than 5 minutes to fix the conflicts that you ge

Re: [PATCH] src/*.cpp: reformatting to increase consistency

2012-10-27 Thread Stephan Witt
Am 27.10.2012 um 15:46 schrieb Lars Gullik Bjønnes : > --- > src/AppleSpellChecker.cpp | 6 +- > src/AspellChecker.cpp | 32 +++-- > src/Author.cpp| 13 +- > src/BiblioInfo.cpp| 233 +- > src/Bidi.cpp | 1 + > src/BranchList.cpp