Re: [PATCH] Re: [PATCH] some dEPM work

2005-10-25 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> You know, the amazing thing is, I just suspected something Martin> like this, but couldn't make it hard. That's team work at its best :) Thanks for testing. I'll apply it. JMarc

Re: [PATCH] Re: [PATCH] some dEPM work

2005-10-24 Thread Martin Vermeer
On Mon, Oct 24, 2005 at 05:59:32PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > It works for me. Does it work for you? Yes. Shove it in. - Martin pgpUXv5sCgYfp.pgp Description: PGP signature

Re: [PATCH] Re: [PATCH] some dEPM work

2005-10-24 Thread Martin Vermeer
On Mon, 2005-10-24 at 17:59 +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> I agree, but with the attached mod. It essentially removes the > Martin> cursor from inside the inset if it chances to go there from a > Martin> deletable empty

[PATCH] Re: [PATCH] some dEPM work

2005-10-24 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I agree, but with the attached mod. It essentially removes the Martin> cursor from inside the inset if it chances to go there from a Martin> deletable empty paragraph; so it is a workaround, not a fix. Martin, you pointed me to

Re: [PATCH] some dEPM work

2005-10-24 Thread Andre Poenitz
On Mon, Oct 24, 2005 at 07:51:44AM +0200, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > What code specifically? I lost track somehow. > > I have enabled bruteFind3 in cursor.C: 998, which fixes the crash (and also > slightly improves cursor navigation inside mathed), but is of course a "

Re: [PATCH] some dEPM work

2005-10-23 Thread Juergen Spitzmueller
Andre Poenitz wrote: > What code specifically? I lost track somehow. I have enabled bruteFind3 in cursor.C: 998, which fixes the crash (and also slightly improves cursor navigation inside mathed), but is of course a "black box" change for all of us. Jürgen

Re: [PATCH] some dEPM work

2005-10-23 Thread Martin Vermeer
On Sat, Oct 22, 2005 at 09:33:46PM +0200, Andre Poenitz wrote: > On Fri, Oct 21, 2005 at 03:07:29PM +0200, Jean-Marc Lasgouttes wrote: > > Martin> Did you try Juergen's remedy? > > > > I'd rather avoid enabling bit parts of code unless Andre tells us it > > is a good idea. > > What code specifica

Re: [PATCH] some dEPM work

2005-10-23 Thread Andre Poenitz
On Fri, Oct 21, 2005 at 03:07:29PM +0200, Jean-Marc Lasgouttes wrote: > Martin> Did you try Juergen's remedy? > > I'd rather avoid enabling bit parts of code unless Andre tells us it > is a good idea. What code specifically? I lost track somehow. Andre'

Re: [PATCH] some dEPM work

2005-10-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> 1/ call recordUndo with the right cursor, and only for the pit >> contains `old' (this is the only paragraph we change) >> >> 2/ when comparing cursors, do not compare pit:s without first >> checking that they are relative to the sam

Re: [PATCH] some dEPM work

2005-10-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Actually the problem is around line 1208. Martin> When going into the inset, cur.depth() is 2 as it should be, Martin> but the deepest inset (which exists) does not seem to be able Martin> to access its text data member. Martin

Re: [PATCH] some dEPM work

2005-10-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Wed, 2005-10-19 at 17:53 +0200, Jean-Marc Lasgouttes wrote: >> > "Jean-Marc" == Jean-Marc Lasgouttes >> <[EMAIL PROTECTED]> writes: >> >> I really cannot make sense of it. >> >> Martin, Help!!! Martin> Jean-Marc, Mart

[PATCH] Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-21 Thread Martin Vermeer
On Wed, 2005-10-19 at 17:53 +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > > Here is the patch FWIW. I still think it would be worth committing it. I agree, but with the attached mod. It essentially removes the cursor from inside t

Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-20 Thread Martin Vermeer
On Wed, 2005-10-19 at 17:53 +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > I really cannot make sense of it. > > Martin, Help!!! Jean-Marc, If I place another line of text under the inset, the nature of the error message changes.

Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-20 Thread Martin Vermeer
On Wed, 2005-10-19 at 21:25 +0300, Martin Vermeer wrote: > On Wed, Oct 19, 2005 at 05:53:07PM +0200, Jean-Marc Lasgouttes wrote: > > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > Yes... look at cursor.C: > > 1201 LyXFont LCursor::getFont() const >1202 { >1203

Re: [PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-19 Thread Martin Vermeer
On Wed, Oct 19, 2005 at 05:53:07PM +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > Jean-Marc> Basically, dEPM compares the tips of cursors without caring > Jean-Marc> whether they are at same depth (insert apples and oranges > Jean-Mar

[PATCH] some dEPM work (was Re: Crash on cursor movement around inset)

2005-10-19 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Basically, dEPM compares the tips of cursors without caring Jean-Marc> whether they are at same depth (insert apples and oranges Jean-Marc> comment here). Here undo is called between two cursors at Jean-Marc> differen