Re: [PATCH] more text paint cleanups

2003-03-17 Thread John Levon
On Mon, Mar 17, 2003 at 11:37:18AM +0100, Jean-Marc Lasgouttes wrote: > It would probably be a good idea to run some profiler on this and see > whether things remain sensible. The results seem a bit odd (playing with TableExamples.lyx) : 0811dec4 594 1.26399 LyXTabular::row_of_cell(int)

Re: [PATCH] more text paint cleanups

2003-03-17 Thread Andre Poenitz
On Mon, Mar 17, 2003 at 11:37:18AM +0100, Jean-Marc Lasgouttes wrote: > It would probably be a good idea to run some profiler on this and see > whether things remain sensible. The only things I would worry about is > complexity effects (like what happens with large tables). I'd even expect these t

Re: [PATCH] more text paint cleanups

2003-03-17 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Sun, Mar 16, 2003 at 07:44:07PM +, John Levon wrote: >> Continuing in the same vein. Trying to make this stuff somewhat >> understandable. Note that this probably makes CHANGED_IN_DRAW >> somewhat slower. Andre> Have you che

Re: [PATCH] more text paint cleanups

2003-03-17 Thread Andre Poenitz
On Sun, Mar 16, 2003 at 07:44:07PM +, John Levon wrote: > Continuing in the same vein. Trying to make this stuff somewhat > understandable. Note that this probably makes CHANGED_IN_DRAW > somewhat slower. Have you checked whether it is still usable on some older machine? Apart from that I rea

Re: [PATCH] more text paint cleanups

2003-03-16 Thread John Levon
On Sun, Mar 16, 2003 at 09:30:49PM +0100, Lars Gullik Bj?nnes wrote: > This one is not as obvious to me as the first one, but it seems to > make things clearer. It's really a first step more than anything else. I really want to deal with all the status() checks in insettext.C somehow (that is, ma

Re: [PATCH] more text paint cleanups

2003-03-16 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | Continuing in the same vein. Trying to make this stuff somewhat | understandable. Note that this probably makes CHANGED_IN_DRAW | somewhat slower. | | 7 files changed, 95 insertions(+), 130 deletions(-) | | Next we see if we can remove the "refresh_y" al

[PATCH] more text paint cleanups

2003-03-16 Thread John Levon
Continuing in the same vein. Trying to make this stuff somewhat understandable. Note that this probably makes CHANGED_IN_DRAW somewhat slower. 7 files changed, 95 insertions(+), 130 deletions(-) Next we see if we can remove the "refresh_y" altogether in the postRowPaint() case. It should not be