Re: [PATCH] metrics fix

2003-07-22 Thread Andre Poenitz
On Tue, Jul 22, 2003 at 12:44:24AM +0100, John Levon wrote: > OK, a better version. This has two obvious remaining problems: > > o minipage - we need to add another width meaning "total width" > for the benefit of the 50% page width calculation etc. > > o inlined ERT - tougher. We need to know th

Re: [PATCH] metrics fix

2003-07-22 Thread John Levon
On Tue, Jul 22, 2003 at 03:56:21PM +0200, Andre Poenitz wrote: > Now, is there a reason to call rowBreakPoint by anything else than by > LyXText::metrics? God knows. john

Re: [PATCH] metrics fix

2003-07-22 Thread Andre Poenitz
On Tue, Jul 22, 2003 at 02:50:30PM +0100, John Levon wrote: > On Tue, Jul 22, 2003 at 10:10:24AM +0200, Andre Poenitz wrote: > > > Ah good. Last time I tried that there were massive drawing problems > > immediately after buffer loading. If that works now, we are moving in > > the right direction.

Re: [PATCH] metrics fix

2003-07-22 Thread John Levon
On Tue, Jul 22, 2003 at 10:10:24AM +0200, Andre Poenitz wrote: > Ah good. Last time I tried that there were massive drawing problems > immediately after buffer loading. If that works now, we are moving in > the right direction. Which version did you apply ? My third one ? > Maybe we should move

Re: [PATCH] metrics fix

2003-07-22 Thread Andre Poenitz
On Tue, Jul 22, 2003 at 12:44:24AM +0100, John Levon wrote: > @@ -311,19 +319,8 @@ int LyXText::singleWidth(ParagraphList:: > // Because of the representation as vertical lines > return 3; > } > -#if 1 > -#warning ins

Re: [PATCH] metrics fix

2003-07-22 Thread Andre Poenitz
On Mon, Jul 21, 2003 at 09:08:07PM +0100, John Levon wrote: > On Mon, Jul 21, 2003 at 08:39:49PM +0100, John Levon wrote: > > > Another patch, taking inspiration from where Andre was heading I > > believe. Compiling it now, probably won't work, but the idea is clear - > > Sigh. Broke insetminipag

Re: [PATCH] metrics fix

2003-07-22 Thread Andre Poenitz
On Mon, Jul 21, 2003 at 07:54:30PM +0100, John Levon wrote: > This moves the inset metrics update from the (very frequent) > singleWidth() function into rowBreakPoint(). This has two advantages : > > o no metrics recalculation for something that should be const-like > o we can work out the remaini

Re: [PATCH] metrics fix

2003-07-21 Thread John Levon
On Mon, Jul 21, 2003 at 08:39:49PM +0100, John Levon wrote: > OK, a better version. This has two obvious remaining problems: o minipage - we need to add another width meaning "total width" for the benefit of the 50% page width calculation etc. o inlined ERT - tougher. We need to know the actual

Re: [PATCH] metrics fix

2003-07-21 Thread John Levon
On Mon, Jul 21, 2003 at 08:39:49PM +0100, John Levon wrote: > Another patch, taking inspiration from where Andre was heading I > believe. Compiling it now, probably won't work, but the idea is clear - Sigh. Broke insetminipage (understandable why, fix is to pass *two* widths in metrics info), but

Re: [PATCH] metrics fix

2003-07-21 Thread John Levon
On Mon, Jul 21, 2003 at 07:54:30PM +0100, John Levon wrote: > The actual red frame drawing itself is a bit tougher. I'm looking into > it. Another patch, taking inspiration from where Andre was heading I believe. Compiling it now, probably won't work, but the idea is clear - dump the horrendous w

[PATCH] metrics fix

2003-07-21 Thread John Levon
This moves the inset metrics update from the (very frequent) singleWidth() function into rowBreakPoint(). This has two advantages : o no metrics recalculation for something that should be const-like o we can work out the remaining width in order to break inset contents properly Please test it.