Re: [PATCH] lyxlex cleanup

2001-12-05 Thread John Levon
On Wed, Dec 05, 2001 at 07:42:12PM +0100, Andre Poenitz wrote: > > > especially if there are more "cases" or (a) and (d) are "enforcing" > > > prerequisites for "//stuff"... > > > > but this loses the semantic information that a and d are mutually exclusive. > > That's important. > > The sema

Re: [PATCH] lyxlex cleanup

2001-12-05 Thread Andre Poenitz
On Wed, Dec 05, 2001 at 06:34:00PM +, John Levon wrote: > > especially if there are more "cases" or (a) and (d) are "enforcing" > > prerequisites for "//stuff"... > > but this loses the semantic information that a and d are mutually exclusive. > That's important. The semantics are the same

Re: [PATCH] lyxlex cleanup

2001-12-05 Thread John Levon
On Wed, Dec 05, 2001 at 07:31:04PM +0100, Andre Poenitz wrote: > What do the code rules say for > > if (a) { > return b; > } else if (d) { > return e; > } else { > // main stuff > return c; > } > > I'd actually prefer > > if (a) { > return b; > } > if (d) { >

Re: [PATCH] lyxlex cleanup

2001-12-05 Thread Andre Poenitz
On Wed, Dec 05, 2001 at 06:17:29PM +, John Levon wrote: > please apply ... What do the code rules say for if (a) { return b; } else if (d) { return e; } else { // main stuff return c; } I'd actually prefer if (a) { return b; } if (d) { return e; }

[PATCH] lyxlex cleanup

2001-12-05 Thread John Levon
please apply ... thanks john -- "Faced with the prospect of rereading this book, I would rather have my brains ripped out by a plastic fork." - Charles Cooper on "Business at the Speed of Thought" Index: src/ChangeLog ===