Re: [PATCH] libiconv support in Scons/Msvc

2006-06-16 Thread Abdelrazak Younes
Bo Peng wrote: Wait, there is another change needed because of this: LINK : fatal error LNK1181: cannot open input file 'iconv.lib' scons: *** [msvc\qt4\lyx.exe] Error 1181 scons: building terminated because of errors. We need env['LIB_ICONV'] that point to the detected lib. Yes, that seems

Re: [PATCH] libiconv support in Scons/Msvc

2006-06-16 Thread Bo Peng
Wait, there is another change needed because of this: LINK : fatal error LNK1181: cannot open input file 'iconv.lib' scons: *** [msvc\qt4\lyx.exe] Error 1181 scons: building terminated because of errors. We need env['LIB_ICONV'] that point to the detected lib. Bo

Re: [PATCH] libiconv support in Scons/Msvc

2006-06-16 Thread Abdelrazak Younes
Bo Peng wrote: On 6/16/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Hello Bo, I had to apply this patch to get libiconv recognized by scons/msvc. The problem is that the GnuWin32 package provide libiconv.lib and not iconv.lib. I did not commit the patch because I guess this change would bre

Re: [PATCH] libiconv support in Scons/Msvc

2006-06-16 Thread Abdelrazak Younes
Bo Peng wrote: msvc does not use that lib prefix, and mingw generated lib has that thing. Is this the problem? I think so yes (note that I did not check that mingw/iconv will fail). I will see how to make mingw happy about this. Good :-) Abdel.

Re: [PATCH] libiconv support in Scons/Msvc

2006-06-16 Thread Bo Peng
On 6/16/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Hello Bo, I had to apply this patch to get libiconv recognized by scons/msvc. The problem is that the GnuWin32 package provide libiconv.lib and not iconv.lib. I did not commit the patch because I guess this change would break scons/mingw.

[PATCH] libiconv support in Scons/Msvc

2006-06-16 Thread Abdelrazak Younes
Hello Bo, I had to apply this patch to get libiconv recognized by scons/msvc. The problem is that the GnuWin32 package provide libiconv.lib and not iconv.lib. I did not commit the patch because I guess this change would break scons/mingw. Abdel. Index: SConstruct ===