Re: [PATCH] lengthcommon.C

2006-07-19 Thread Georg Baum
Michael Gerz wrote: > Georg Baum wrote: > >>>-N_("theight%"), N_("pheight%"), "" }; >>>+N_("Text Height %"), N_("Page Height %") }; >>> >>> >>Sorry, but I did only notice this now: You forgot the final "". Please >>fix. >> >> > > I didn't forget it. It wasn't there before.

Re: [PATCH] lengthcommon.C

2006-07-19 Thread Michael Gerz
Georg Baum wrote: -N_("theight%"), N_("pheight%"), "" }; +N_("Text Height %"), N_("Page Height %") }; Sorry, but I did only notice this now: You forgot the final "". Please fix. I didn't forget it. It wasn't there before. Anyway, I will commit in a few seconds. Micha

Re: [PATCH] lengthcommon.C

2006-07-19 Thread Georg Baum
Michael Gerz wrote: > -N_("theight%"), N_("pheight%"), "" }; > +N_("Text Height %"), N_("Page Height %") }; Sorry, but I did only notice this now: You forgot the final "". Please fix. Georg

Re: [PATCH] lengthcommon.C

2006-07-18 Thread Michael Gerz
Georg Baum wrote: I have a nervous feeling that these strings are parsed somewhere. If you made sure that that is not the case then this is a good change. I would maybe even go further and use real language like e.g. "page width %" (or capitalized?) I checked that the string are handled corre

Re: [PATCH] lengthcommon.C

2006-07-14 Thread Georg Baum
Michael Gerz wrote: > How about this change? I have a nervous feeling that these strings are parsed somewhere. If you made sure that that is not the case then this is a good change. I would maybe even go further and use real language like e.g. "page width %" (or capitalized?) Georg

Re: [PATCH] lengthcommon.C

2006-07-14 Thread Lars Gullik Bjønnes
Michael Gerz <[EMAIL PROTECTED]> writes: | How about this change? If you have looked at the result in the gui and figure it ok, then sure. -- Lgb

[PATCH] lengthcommon.C

2006-07-14 Thread Michael Gerz
How about this change? Index: lengthcommon.C === --- lengthcommon.C (Revision 14449) +++ lengthcommon.C (Arbeitskopie) @@ -46,18 +46,9 @@ char const * const unit_name_gui[] = { N_("sp"), N_("pt"), N_("bp"), N_("dd")