Re: [PATCH] immediatly display saved filename in tab

2007-02-07 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> Jean-Marc, Peter, I don't think this has been committed, yet. It is in: http://www.lyx.org/trac/changeset/17044 JMarc

Re: [PATCH] immediatly display saved filename in tab

2007-02-07 Thread Michael Gerz
Jean-Marc, Peter, I don't think this has been committed, yet. Michael Jean-Marc Lasgouttes schrieb: "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Jean-Marc Lasgouttes wrote: ve some remarks about your patch. I Peter> think the code can be further simplified.

Re: [PATCH] immediatly display saved filename in tab

2007-02-05 Thread Bernhard Roider
Angus Leeming wrote: Bernhard Roider wrote: i agree to license my contributions to LyX under the GPL version 2 or later. It's taken a little while, but your name is now up in lights at http://www.lyx.org/about/credits.php and http://www.lyx.org/about/blanket-permission.php Regards, Angus T

Re: [PATCH] immediatly display saved filename in tab

2007-02-05 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Bernhard Roider wrote: >> i agree to license my contributions to LyX under the GPL version 2 >> or later. Angus> It's taken a little while, but your name is now up in lights at Angus> http://www.lyx.org/about/credits.php and Angus>

Re: [PATCH] immediatly display saved filename in tab

2007-02-04 Thread Angus Leeming
Bernhard Roider wrote: > i agree to license my contributions to LyX under the GPL version 2 or > later. It's taken a little while, but your name is now up in lights at http://www.lyx.org/about/credits.php and http://www.lyx.org/about/blanket-permission.php Regards, Angus

Re: [PATCH] immediatly display saved filename in tab

2007-02-04 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: >> Since it is not my code, I'll let you check it and commit. Peter> No problem, please check in! I'll do that. JMarc

Re: [PATCH] immediatly display saved filename in tab

2007-02-04 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Since it is not my code, I'll let you check it and commit. Abdelrazak> IMHO, since you touched it, this also becomes your code. Abdelrazak> Peter is a clever guy and will recognize that you did the Abdelrazak> right thing, obv

Re: [PATCH] immediatly display saved filename in tab

2007-02-02 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> Jean-Marc Lasgouttes wrote: ve some remarks about your patch. I > Peter> think the code can be further >>> simplified. > > Peter> I've checked in attached simplified patch. > > Here are some additio

Re: [PATCH] immediatly display saved filename in tab

2007-02-02 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Jean-Marc Lasgouttes wrote: ve some remarks about your patch. I Peter> think the code can be further simplified. Peter> I've checked in attached simplified patch. Here are some additional changes (the par

Re: [PATCH] immediatly display saved filename in tab

2007-02-02 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Jean-Marc Lasgouttes wrote: ve some remarks about your patch. I Peter> think the code can be further >> simplified. Peter> I've checked in attached simplified patch. Here are some additional changes (the part in geometry stuff is j

Re: [PATCH] immediatly display saved filename in tab

2007-02-01 Thread Peter Kümmel
When you are a "I compile LyX by myself" LyX'er you could move the tabbars to the bottom ;) > > Index: src/frontends/qt4/GuiView.C > === > --- src/frontends/qt4/GuiView.C (revision 17013) > +++ src/frontends/qt4/GuiView.C

Re: [PATCH] immediatly display saved filename in tab

2007-02-01 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: ve some remarks about your patch. I think the code can be further > simplified. I've checked in attached simplified patch. > > Index: src/frontends/qt4/GuiView.C > === > --- src/frontends/qt4/GuiVie

Re: [PATCH] immediatly display saved filename in tab

2007-02-01 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: > > Peter> Here a patch to simplify the tabbar code. As JMarc suggested > Peter> the tabbars are always build from scratch, when the buffer has > Peter> changed. > > I have some remarks about your patch. I think the code can be further > simplified. I'm glad not havin

Re: [PATCH] immediatly display saved filename in tab

2007-02-01 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Jean-Marc Lasgouttes wrote: >>> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: >> Peter> I've tried to minimize the reordering: when a file named as Peter> AAA.lyx is opened it will be not at the first place (which Peter

Re: [PATCH] immediatly display saved filename in tab

2007-01-31 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> I've tried to minimize the reordering: when a file named as > Peter> AAA.lyx is opened it will be not at the first place (which > Peter> would be the case when I rebuild the tabbar from scratch) b

Re: [PATCH] immediatly display saved filename in tab

2007-01-31 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> I've tried to minimize the reordering: when a file named as > Peter> AAA.lyx is opened it will be not at the first place (which > Peter> would be the case when I rebuild the tabbar from scratch) b

Re: [PATCH] immediatly display saved filename in tab

2007-01-31 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> I've tried to minimize the reordering: when a file named as Peter> AAA.lyx is opened it will be not at the first place (which Peter> would be the case when I rebuild the tabbar from scratch) but Peter> on the right, only when a a

Re: [PATCH] immediatly display saved filename in tab

2007-01-30 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> In void GuiView::updateTab() I make use of the stl to rebuild > Peter> the tab bar and I don't preserve the previous order. > > Wow! This function seems terribly complicated to me. Could you explain

Re: [PATCH] immediatly display saved filename in tab

2007-01-30 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> In void GuiView::updateTab() I make use of the stl to rebuild Peter> the tab bar and I don't preserve the previous order. Wow! This function seems terribly complicated to me. Could you explain why you can't just build the tab list f

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Peter Kümmel wrote: Bernhard Roider wrote: Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - but the discussion then was only about the status of status.15x ;-) After saving a new file or "save as.." the filename is not update

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Bernhard Roider wrote: >>> Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - >>> but the discussion then was only about the status of status.15x ;-) >>> >>> After saving a new file or "save as.." the filename is not updated in

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Abdelrazak Younes
Peter Kümmel wrote: Bernhard Roider wrote: Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - but the discussion then was only about the status of status.15x ;-) After saving a new file or "save as.." the filename is not updated in the tab. This patch fixes this. Bernhard

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Peter Kümmel
Bernhard Roider wrote: > Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - > but the discussion then was only about the status of status.15x ;-) > > After saving a new file or "save as.." the filename is not updated in > the tab. This patch fixes this. > > Bernhard > > Co

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Angus Leeming
Bernhard Roider <[EMAIL PROTECTED]> writes: > i agree to license my contributions to LyX under the GPL version 2 or later. Thank you and welcome aboard! Angus

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> Uwe Stöhr wrote: After saving a new file or "save as.." the filename is not updated in >>> the tab. This patch fixes this. >>> I checked out you patch (what Abdel comitted) and it work

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Bernhard Roider
Bernhard, I see that you're sending a succession of patches to this list and that some of them are getting into the code base. Could I get you to reply to this email (to lyx-devel please) saying that you agree to licence your contributions to LyX under the GPL version 2 or later? Of cour

Re: [PATCH] immediatly display saved filename in tab

2007-01-29 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Uwe Stöhr wrote: >>> After saving a new file or "save as.." the filename is not updated >>> in >> the tab. >>> This patch fixes this. >> I checked out you patch (what Abdel comitted) and it works. But I >> noticed one minor thing: >

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Peter Kümmel
Uwe Stöhr wrote: >> After saving a new file or "save as.." the filename is not updated in > the tab. >> This patch fixes this. > > I checked out you patch (what Abdel comitted) and it works. But I > noticed one minor thing: > > When you have opened two files and save one in the first tab under a

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Angus Leeming
Bernhard Roider <[EMAIL PROTECTED]> writes: > Uwe Stöhr already denoted this small bug in his mail from 03 > Jan 2007 - but the discussion then was only about the status of > status.15x > > After saving a new file or "save as.." the filename is not > updated in the tab. This patch fixes this. Be

Re:[PATCH] immediatly display saved filename in tab

2007-01-28 Thread Uwe Stöhr
> After saving a new file or "save as.." the filename is not updated in the tab. > This patch fixes this. I checked out you patch (what Abdel comitted) and it works. But I noticed one minor thing: When you have opened two files and save one in the first tab under a new name its tab is set to th

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bernhard Roider wrote: Regarding the tab update problem: Technically it would be better, i think, if we could move lyx_view_->updateTab() into the function writeAs(...). Is the LyXView accessible from the Buffer to manage this? No and it will never be the case becau

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Abdelrazak Younes
Bernhard Roider wrote: Abdelrazak Younes wrote: Bernhard Roider wrote: Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - but the discussion then was only about the status of status.15x ;-) After saving a new file or "save as.." the filename is not updated in the tab. Th

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Peter Kümmel
Bernhard Roider wrote: > Abdelrazak Younes wrote: >> Bernhard Roider wrote: >>> Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 >>> - but the discussion then was only about the status of status.15x ;-) >>> >>> After saving a new file or "save as.." the filename is not updated

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Abdelrazak Younes
Bernhard Roider wrote: Regarding the tab update problem: Technically it would be better, i think, if we could move lyx_view_->updateTab() into the function writeAs(...). Is the LyXView accessible from the Buffer to manage this? No and it will never be the case because this would break the MV

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Bernhard Roider
- && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer) - && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly)) + && !lyxaction.funcHasFlag(action, LyXAction::NoBuffer) + && !lyx

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Peter Kümmel
Abdelrazak Younes wrote: > Bernhard Roider wrote: >> Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 >> - but the discussion then was only about the status of status.15x ;-) >> >> After saving a new file or "save as.." the filename is not updated in >> the tab. This patch fixe

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Peter Kümmel
Bernhard Roider wrote: > Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - > but the discussion then was only about the status of status.15x ;-) > > After saving a new file or "save as.." the filename is not updated in > the tab. This patch fixes this. > > Bernhard > > > -

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Bernhard Roider
Abdelrazak Younes wrote: Bernhard Roider wrote: Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - but the discussion then was only about the status of status.15x ;-) After saving a new file or "save as.." the filename is not updated in the tab. This patch fixes this.

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread christian . ridderstrom
On Sun, 28 Jan 2007, Abdelrazak Younes wrote: Second option would be that you request SVN access Bernhard. The laws and duties related to such access are listed somewhere in the archive by Georg. If you agree with them (and I think you will ;-)) please come in! If you finds those laws and dut

Re: [PATCH] immediatly display saved filename in tab

2007-01-28 Thread Abdelrazak Younes
Bernhard Roider wrote: Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - but the discussion then was only about the status of status.15x ;-) After saving a new file or "save as.." the filename is not updated in the tab. This patch fixes this. It looks good to me. As thi

[PATCH] immediatly display saved filename in tab

2007-01-27 Thread Bernhard Roider
Uwe Stöhr already denoted this small bug in his mail from 03 Jan 2007 - but the discussion then was only about the status of status.15x ;-) After saving a new file or "save as.." the filename is not updated in the tab. This patch fixes this. Bernhard Index: src/lyxfunc.C ==