Re: [PATCH] get rid of Paragraph::isWord

2004-11-19 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > You did that to what code? The spellchecker or lyxfind? Good question, I totally confused the two. lyxfind I guess. ;-) > The problem is that this code does not use the dispatch mechanism, but > direct calls to the kernel. Aha! That's the problem ;-) Well then jus

Re: [PATCH] get rid of Paragraph::isWord

2004-11-19 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Jean-Marc Lasgouttes wrote: >> One remaining bug (which already existed) is that the first word is >> always skipped. Actually, I feel that spellcheck should always do >> the whole document instead of starting from cursor.

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > One remaining bug (which already existed) is that the first word is > always skipped. Actually, I feel that spellcheck should always do the > whole document instead of starting from cursor. We may want to add the > possibility to spellcheck a selection. I think you a

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread John Spray
On Thu, 2004-11-18 at 15:23 +0100, Jean-Marc Lasgouttes wrote: > I wonder how many people are really aware that spellchecking starts > from cursor... I think that this is a very bad default setting. We should definitely change to checking the whole document by default, in my opinion. > Helge> Als

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> just let me update. Too late, I committed it. JMarc

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> This plays into my nvi patch. (I already did those there) > | I can remove that if you know you are going to apply this thing very | soon. Otherwise, I'll just let you update

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> This plays into my nvi patch. (I already did those there) I committed a version that does not touch InsetSpace. JMarc

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Jean-Marc Lasgouttes
> "Helge" == Helge Hafting <[EMAIL PROTECTED]> writes: Helge> Well, spellchecking the whole document is fine when you just Helge> wrote it, or if there's lots of changes all over the place. Helge> "From cursor" is very useful as long as ispell occationally Helge> crashes, I can then keep goin

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> This plays into my nvi patch. (I already did those there) I can remove that if you know you are going to apply this thing very soon. Otherwise, I'll just let you update your patch :) JMarc

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Helge Hafting
Jean-Marc Lasgouttes wrote: One remaining bug (which already existed) is that the first word is always skipped. Actually, I feel that spellcheck should always do the whole document instead of starting from cursor. We may want to add the possibility to spellcheck a selection. Well, spellchecking

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars, any objection? Not from me. | Index: src/insets/ChangeLog | === | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/ChangeLog,v | retrieving revision 1.1076 | diff -u -p -

Re: [PATCH] get rid of Paragraph::isWord

2004-11-18 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following patch gets rid of Paragraph::isWord and of Jean-Marc> various things that are not needed anymore due to this. Jean-Marc> Note that as a consequence numbers are considered as part Jean-Marc> of words. Thi

[PATCH] get rid of Paragraph::isWord (was: Re: [PATCH] make insetlatexaccents real letters)

2004-11-17 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> OK, here is the difference between the inclusion and the Jean-Marc> exclusion method: isWord considers the following characters Jean-Marc> as part of a word, while isLetter does not: Jean-Marc> "$'*<=>_`|0123456789 J