Re: [PATCH] do not replace deleted text

2007-06-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > It looks better, but I'll let Michael decide. OK. Michael, if you're fine with this as well, just commit it. Jürgen

Re: [PATCH] do not replace deleted text

2007-06-19 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> I see. Like in the attached? (I don't see the need to do the Jürgen> test for multiple paragraphs) It looks better, but I'll let Michael decide. JMarc

Re: [PATCH] do not replace deleted text

2007-06-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > >> Is the thing correct when there is no selection? I would think the > >> replace() then searches for the next hit. Of course, this is > >> difficult to get right, but at least a FIXME would be useful. > > Jürgen> I would think everythink would be OK if the "replace"

Re: [PATCH] do not replace deleted text

2007-06-19 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> Jean-Marc Lasgouttes wrote: >> Is the thing correct when there is no selection? I would think the >> replace() then searches for the next hit. Of course, this is >> difficult to get right, but at least a FIXME would be useful

Re: [PATCH] do not replace deleted text

2007-06-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Is the thing correct when there is no selection? I would think the > replace() then searches for the next hit. Of course, this is difficult > to get right, but at least a FIXME would be useful. I would think everythink would be OK if the "replace" and "replace all" b

Re: [PATCH] do not replace deleted text

2007-06-19 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> Hi, the following patch by Jürgen (with a minor fix by Michael> myself) prevents the replacement of deleted text. Michael> I tested the fix and it works. Is the thing correct when there is no selection? I would think the replac

Re: [PATCH] do not replace deleted text

2007-06-18 Thread Michael Gerz
Michael Gerz schrieb: Hi, the following patch by Jürgen (with a minor fix by myself) prevents the replacement of deleted text. I tested the fix and it works. Even with this patch there are still a few minor problems with the search&replace dialog: Nevertheless, I am asking for another OK.

[PATCH] do not replace deleted text

2007-06-18 Thread Michael Gerz
Hi, the following patch by Jürgen (with a minor fix by myself) prevents the replacement of deleted text. I tested the fix and it works. Even with this patch there are still a few minor problems with the search&replace dialog: - Replace/ReplaceAll is always activated when the dialog opens -