Re: [PATCH] delete BufferView::text() method.

2006-09-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I think it would be a good solution indeed. At the end, Abdelrazak> the main InsetText is very special and deserves some Abdelrazak> special treatment. Yes. Also tabular cells should be InsetCell. InsetText should be

Re: [PATCH] delete BufferView::text() method.

2006-09-17 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sat, Sep 16, 2006 at 03:20:36PM +0200, Abdelrazak Younes wrote: Comments? I am about to re-evaluate my stance about parent inset pointers being bad. [It's already lasting for a while...] If we had them, there was a natural solution fo this the main text problem. Alte

Re: [PATCH] delete BufferView::text() method.

2006-09-16 Thread Andre Poenitz
On Sat, Sep 16, 2006 at 03:20:36PM +0200, Abdelrazak Younes wrote: > Comments? I am about to re-evaluate my stance about parent inset pointers being bad. [It's already lasting for a while...] If we had them, there was a natural solution fo this the main text problem. Alternativly we could of co

Re: [PATCH] delete BufferView::text() method.

2006-09-16 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 16. September 2006 15:20 schrieb Abdelrazak Younes: Comments? Abdel. delete_BufferView_text_method.patch Index: src/BufferView.C === --- src/BufferView.C(revision 15013) +++ src/BufferView.C(

Re: [PATCH] delete BufferView::text() method.

2006-09-16 Thread Georg Baum
Am Samstag, 16. September 2006 15:20 schrieb Abdelrazak Younes: > Comments? > > Abdel. > delete_BufferView_text_method.patch > Index: src/BufferView.C > === > --- src/BufferView.C(revision 15013) > +++ src/BufferView.C(worki

Re: [PATCH] delete BufferView::text() method.

2006-09-16 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Comments? I am ok with it. You've just broken the fastest OK record ;-) Committed. Abdel.

Re: [PATCH] delete BufferView::text() method.

2006-09-16 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Comments? I am ok with it. -- Lgb

[PATCH] delete BufferView::text() method.

2006-09-16 Thread Abdelrazak Younes
Comments? Abdel. Index: src/BufferView.C === --- src/BufferView.C(revision 15013) +++ src/BufferView.C(working copy) @@ -1208,12 +1208,6 @@ } -LyXText * BufferView::text() const -{ - return buffer_ ? &buffer_->text