Re: [PATCH] delete BufferView::firstLayout()

2006-08-24 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Abdelrazak Younes wrote: You may be right indeed. But it seems that updateLayoutChoice does a setLayout. Is it necessary to do another one? Maybe not. Actually it may well be that the Buffer

Re: [PATCH] delete BufferView::firstLayout()

2006-08-24 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> That's because I created it :-). It was cut&paste from the Abdelrazak> second part of the former BufferView::pimpl::setBuffer(). So it is not that I am getting old, then. JMarc

Re: [PATCH] delete BufferView::firstLayout()

2006-08-24 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Abdelrazak Younes wrote: You may be right indeed. But it seems that updateLayoutChoice does a setLayout. Is it necessary to do another one? Maybe not. Actually it may well be that the Buffer

Re: [PATCH] delete BufferView::firstLayout()

2006-08-24 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Abdelrazak Younes wrote: You may be right indeed. But it seems that updateLayoutChoice does a setLayout. Is it necessary to do another one? >>> Maybe not. Actually it may well be that the >>> BufferView::Pim

[PATCH] delete BufferView::firstLayout() (was Re: [PATCH] update layout lists before setting layout

2006-08-24 Thread Abdelrazak Younes
Abdelrazak Younes wrote: You may be right indeed. But it seems that updateLayoutChoice does a setLayout. Is it necessary to do another one? Maybe not. Actually it may well be that the BufferView::Pimpl::firstLayout() method can go altogether. updateLayoutChoice() will set the layout that matc