Re: [PATCH] convert MathParser to unicode

2006-11-04 Thread Enrico Forestieri
On Sat, Nov 04, 2006 at 11:43:18AM +0100, Georg Baum wrote: > Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes: > > Abdelrazak Younes wrote: > > > Georg, Andre, Lars, > > > > > > Please review this patch; I am not quite sure these are the correct > > > fixes for the MSVC warning. But

Re: [PATCH] convert MathParser to unicode

2006-11-04 Thread Abdelrazak Younes
Georg Baum wrote: Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes: Abdelrazak Younes wrote: Georg, Andre, Lars, Please review this patch; I am not quite sure these are the correct fixes for the MSVC warning. But it seems to parse math correctly. It was not (due to the size proble

Re: [PATCH] convert MathParser to unicode

2006-11-04 Thread Georg Baum
Am Samstag, 4. November 2006 11:24 schrieb Abdelrazak Younes: > Abdelrazak Younes wrote: > > Georg, Andre, Lars, > > > > Please review this patch; I am not quite sure these are the correct > > fixes for the MSVC warning. But it seems to parse math correctly. > > It was not (due to the size probl

Re: [PATCH] convert MathParser to unicode

2006-11-04 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Georg, Andre, Lars, Please review this patch; I am not quite sure these are the correct fixes for the MSVC warning. But it seems to parse math correctly. It was not (due to the size problem pointed out by Asger). What do you think of this one? IIRC, this will enabl

Re: [PATCH] convert MathParser to unicode

2006-11-04 Thread Abdelrazak Younes
Asger Ottar Alstrup wrote: Abdelrazak Younes wrote: Please review this patch; I am not quite sure these are the correct fixes for the MSVC warning. But it seems to parse math correctly. > -CatCode theCatcode[256]; +CatCode theCatcode[sizeof(lyx::char_type)]; Hm, is sizeof(lyx::char_type) no

Re: [PATCH] convert MathParser to unicode

2006-11-04 Thread Asger Ottar Alstrup
Abdelrazak Younes wrote: Please review this patch; I am not quite sure these are the correct fixes for the MSVC warning. But it seems to parse math correctly. > -CatCode theCatcode[256]; +CatCode theCatcode[sizeof(lyx::char_type)]; Hm, is sizeof(lyx::char_type) not 4? I think you mean 1 <

[PATCH] convert MathParser to unicode

2006-11-04 Thread Abdelrazak Younes
Georg, Andre, Lars, Please review this patch; I am not quite sure these are the correct fixes for the MSVC warning. But it seems to parse math correctly. Abdel. Index: MathParser.C === --- MathParser.C(revision 15714) +++