Re: [PATCH] centering float contents

2003-09-19 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Let's apply that, it will always be possible to refine it later. We done. > may even want to apply it for 1.3.4 (we'll see). just tell me then. Jürgen. > JMarc

Re: [PATCH] centering float contents

2003-09-18 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Angus Leeming wrote: >> Nonsense. It is your cake with my icing. Please apply yourself. Juergen> If you insist... But you won't stop me adding you to the Juergen> changelogs. Before I apply, though, I want to have at lea

Re: [PATCH] centering float contents

2003-09-18 Thread Andre Poenitz
On Thu, Sep 18, 2003 at 04:05:56PM +0200, Juergen Spitzmueller wrote: > If you insist... But you won't stop me adding you to the changelogs. > Before I apply, though, I want to have at least a "go" or "needs further > discussion" from Jean-Marc and from Lars. Don't get ridiculous. Andre'

Re: [PATCH] centering float contents

2003-09-18 Thread Juergen Spitzmueller
Angus Leeming wrote: > Nonsense. It is your cake with my icing. Please apply yourself. If you insist... But you won't stop me adding you to the changelogs. Before I apply, though, I want to have at least a "go" or "needs further discussion" from Jean-Marc and from Lars. Juergen.

Re: [PATCH] centering float contents

2003-09-18 Thread Angus Leeming
Juergen Spitzmueller wrote: > Angus Leeming wrote: >> Jürgen, I think that the attached patch is conceptually the same as your >> original and (thanks to André) is easier to follow. Please review. > > Except for one typo (below): perfect. Many thanks! > Since I do not want to claim the credit for

Re: [PATCH] centering float contents

2003-09-18 Thread Juergen Spitzmueller
Angus Leeming wrote: > Jürgen, I think that the attached patch is conceptually the same as your > original and (thanks to André) is easier to follow. Please review. Except for one typo (below): perfect. Many thanks! Since I do not want to claim the credit for this undeservedly, I let you apply th

Re: [PATCH] centering float contents

2003-09-18 Thread Angus Leeming
Andre Poenitz wrote: > On Thu, Sep 18, 2003 at 10:55:53AM +, Angus Leeming wrote: >> Suitably abashed, I attach the patch. > Some whitespace issues... > Andre' To paraphrase King Henry in T.S.Eliot's Murder in the Cathedral, "Who will rid me of this pedantic German? Jürgen, I think

Re: [PATCH] centering float contents

2003-09-18 Thread Andre Poenitz
On Thu, Sep 18, 2003 at 10:55:53AM +, Angus Leeming wrote: > Suitably abashed, I attach the patch. Some whitespace issues... Andre'

Re: [PATCH] centering float contents

2003-09-18 Thread Angus Leeming
Andre Poenitz wrote: > On Thu, Sep 18, 2003 at 10:01:44AM +, Angus Leeming wrote: >> So, the remaining task is to ascertain which correction to apply. >> Something like this (I have more energy this morning ;-) should do >> it: > > Gosh. > > Too much C++ consumption is bad for your mental hea

Re: [PATCH] centering float contents

2003-09-18 Thread Andre Poenitz
On Thu, Sep 18, 2003 at 10:01:44AM +, Angus Leeming wrote: > So, the remaining task is to ascertain which correction to apply. > Something like this (I have more energy this morning ;-) should do > it: Gosh. Too much C++ consumption is bad for your mental health. > typedef std::pair StrPai

Re: [PATCH] centering float contents

2003-09-18 Thread Angus Leeming
Juergen Spitzmueller wrote: > this looks very sophisticated :-) > I have vaguely thought about something like this, but then I was not > shure if it was worth the effort. Probably it is, though. I will > happily adapt this (if we agree on the fix as such). > > Some question out of interest: > 1. w

Re: [PATCH] centering float contents

2003-09-17 Thread Andre Poenitz
On Wed, Sep 17, 2003 at 07:54:08PM +0200, Juergen Spitzmueller wrote: > Angus Leeming wrote: > > However, since you ask, is there any reason for noTrivlistCentering to be a > > paragraph member function? Why not: > > > > namespace { > > no reason. can you explain the pros and cons in short, please

Re: [PATCH] centering float contents

2003-09-17 Thread Juergen Spitzmueller
Angus Leeming wrote: > However, since you ask, is there any reason for noTrivlistCentering to be a > paragraph member function? Why not: > > namespace { no reason. can you explain the pros and cons in short, please? > Shame that your change messes up the code. > > How about client code that looke

Re: [PATCH] centering float contents

2003-09-17 Thread Juergen Spitzmueller
Angus Leeming wrote: > Really simple question (more complex solution? follows) > > Most of these switch left for right. Eg > + if (noTrivlistCentering()) > + os << "\\begin{raggedright}"; > + else > + os << "\\begin{flushleft}"; this is correct. > However,

Re: [PATCH] centering float contents

2003-09-17 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I am all for the use of \begin{centering}...\end{centering}, except > that we need to make sure that there is a \par break before the \end Yes, in contrary to the patch on bugzilla, I have changed this in my latest patch (in parallel to the "usual" end tags): @@ -77

Re: [PATCH] centering float contents

2003-09-17 Thread Andre Poenitz
On Wed, Sep 17, 2003 at 02:43:40PM +0200, Jean-Marc Lasgouttes wrote: > Andre> I was under the impression that > Andre> \begin{centering}...\end{centering} added extra vertical > Andre> space... > > No, it is \begin{center}...\end{center}. > > AFAIK, for any macro \foo, \begin{foo}...\end{foo} ha

Re: [PATCH] centering float contents

2003-09-17 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Wed, Sep 17, 2003 at 02:34:35PM +0200, Jean-Marc Lasgouttes Andre> wrote: >> > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> >> writes: >> Juergen> LaTeXers usually recommend to use \centering inside floats to Juerge

Re: [PATCH] centering float contents

2003-09-17 Thread Andre Poenitz
On Wed, Sep 17, 2003 at 02:34:35PM +0200, Jean-Marc Lasgouttes wrote: > > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > > Juergen> LaTeXers usually recommend to use \centering inside floats to > Juergen> avoid this problem: > Juergen> http://www.tex.ac.uk/cgi-bin/texfaq2html?

Re: [PATCH] centering float contents

2003-09-17 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> LaTeXers usually recommend to use \centering inside floats to Juergen> avoid this problem: Juergen> http://www.tex.ac.uk/cgi-bin/texfaq2html?label=vertspacefloat Juergen> However, \begin{centering}...\end{centering} is b

Re: [PATCH] centering float contents

2003-09-17 Thread Angus Leeming
Juergen Spitzmueller wrote: > Juergen Spitzmueller wrote: >> http://bugzilla.lyx.org/show_bug.cgi?id=1290 >> >> This patch is on bugzilla for a while, but since there's no >> discussion I thought I'd bring it up here. > > really no objections? > > Juergen. Weelll, the idea looks fine. However

Re: [PATCH] centering float contents

2003-09-17 Thread Angus Leeming
Juergen Spitzmueller wrote: > Juergen Spitzmueller wrote: >> http://bugzilla.lyx.org/show_bug.cgi?id=1290 >> >> This patch is on bugzilla for a while, but since there's no discussion I >> thought I'd bring it up here. > > really no objections? > > Juergen. Really simple question (more complex s

Re: [PATCH] centering float contents

2003-09-17 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > http://bugzilla.lyx.org/show_bug.cgi?id=1290 > > This patch is on bugzilla for a while, but since there's no discussion I > thought I'd bring it up here. really no objections? Juergen.

[PATCH] centering float contents

2003-09-11 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1290 This patch is on bugzilla for a while, but since there's no discussion I thought I'd bring it up here. As you know, LyX does not center (in general: align) float contents (figures, tabulars) right, because \begin{center}...\end{center} is implemented