Re: [PATCH] bug 1947: cursor placement in paragraph description

2005-11-07 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: Thanks for the explanation. >> And does the patch work for you? Juergen> Yes. I committed it. JMarc

Re: [PATCH] bug 1947: cursor placement in paragraph description

2005-11-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> Thanks for the explanation. > > And does the patch work for you? Yes. Jürgen

Re: [PATCH] bug 1947: cursor placement in paragraph description

2005-11-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Thanks for the explanation. And does the patch work for you? JMarc

Re: [PATCH] bug 1947: cursor placement in paragraph description

2005-11-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Juergen> Ah! This one made my forehead bleed. > > Well, before I understood it was a font problem, I was quite unhappy > to have to understand all this margins stuff. Yes, that's where I got stuck. > FontSpan is an optimization to avoid looking up the current font at

Re: [PATCH] bug 1947: cursor placement in paragraph description

2005-11-03 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> The problem was that the code in LyXText::cursorX did not notice >> that the font changes between the description label and its main >> text, and thus used the bold font metrics. Juergen> A

Re: [PATCH] bug 1947: cursor placement in paragraph description

2005-11-03 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > The problem was that the code in LyXText::cursorX did not notice that > the font changes between the description label and its main text, and > thus used the bold font metrics. Ah! This one made my forehead bleed. > The solution is to make sure that a FontSpan does n

[PATCH] bug 1947: cursor placement in paragraph description

2005-11-03 Thread Jean-Marc Lasgouttes
The problem was that the code in LyXText::cursorX did not notice that the font changes between the description label and its main text, and thus used the bold font metrics. The solution is to make sure that a FontSpan does not span across beginOfBody. Comments? JMarc Index: src/ChangeLog