On Thu, Jul 28, 2005 at 09:49:08PM +0100, John Levon wrote:
> I did:
>
> Index: text2.C
> ===
> RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text2.C,v
> retrieving revision 1.624
> diff -u -a -p -r1.624 text2.C
> --- text2.C 18 Ju
On Fri, Jul 29, 2005 at 10:23:08AM +0200, Lars Gullik Bjønnes wrote:
> Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> | John Levon wrote:
> >> Hmm, I sent a patch for this already :/ Did you not notice the bug was
> >> assigned to me?
> >
> | I noted that after I have done the patch, and I d
John Levon wrote:
> It worked for me, but there's no harm in further testing; I don't know
> the new code after all
It looks very sensible. Tested an committed.
Jürgen
On Fri, Jul 29, 2005 at 10:21:50AM +0200, Juergen Spitzmueller wrote:
> I noted that after I have done the patch, and I didn't notice your patch,
> that's why I sent it. But I didn't intend to step on your toes.
No problem, just seems a bit of a waste of our time which is surely
precious :)
> I
Lars Gullik Bjønnes wrote:
> | Well, it was a long day. Anyway, following that bug was not useless after
> | all.
>
> Note that this is not aimed at you in paritcular, we can all do
> better.
I didn't read it that way. And I also agree about the bugzilla use.
Jürgen
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>> This is why we need to be a bit more structured in our bugzilla
>> usage...
>
| Well, it was a long day. Anyway, following that bug was not useless after all.
Note that this is not aimed at you in paritcular, we can
Lars Gullik Bjønnes wrote:
> This is why we need to be a bit more structured in our bugzilla
> usage...
Well, it was a long day. Anyway, following that bug was not useless after all.
> Please test and then commit is test works out ok.
I'll do that.
Jürgen
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
| John Levon wrote:
>> Hmm, I sent a patch for this already :/ Did you not notice the bug was
>> assigned to me?
>
| I noted that after I have done the patch, and I didn't notice your patch,
| that's why I sent it. But I didn't intend to step on yo
John Levon wrote:
> Hmm, I sent a patch for this already :/ Did you not notice the bug was
> assigned to me?
I noted that after I have done the patch, and I didn't notice your patch,
that's why I sent it. But I didn't intend to step on your toes.
> Index: text2.C
> ==
On Thu, Jul 28, 2005 at 08:07:11PM +0200, Juergen Spitzmueller wrote:
> InsertStringAsLines has set the Cursor with the lastpos of the last
> paragraph,
> but _in_ the first paragraph: pit and pos from two different paragraphs had
> been used. Therefore, LyX asserted when the last paragraph was
InsertStringAsLines has set the Cursor with the lastpos of the last paragraph,
but _in_ the first paragraph: pit and pos from two different paragraphs had
been used. Therefore, LyX asserted when the last paragraph was bigger than
the first. The attached patch corrects this.
The remaining differ
I don't really know what I'm doing here, but this smells like old code
that's no longer necessary, and is actively bad. I can't find any
problem with my change.
The setCursor() call was terribly dubious.
regards
john
Index: text2.C
===
12 matches
Mail list logo
