Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-06 Thread Andre Poenitz
On Wed, Jun 01, 2005 at 03:26:47PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Hmmm. This > > Martin> 43 InsetCollapsable::InsetCollapsable > Martin> 44 (BufferParams const & bp, CollapseStatus status) > Martin> 45

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-06 Thread Andre Poenitz
On Wed, Jun 01, 2005 at 03:08:57PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> I would say there are two different real value pairs, as there > Martin> are two insets within each other. The collapsable inset uses > Martin> its own d

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-02 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following (trivial) patch fixes bug 1890. Although it Jean-Marc> is a satisfactory fix (insert the optarg inset as open Jean-Marc> instead of collapsed, like for all other collapsable Jean-Marc> insets), it hides

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >>> "Jean-Marc" == Jean-Marc Lasgouttes >>> <[EMAIL PROTECTED]> writes: >> Jean-Marc> The following (trivial) patch fixes bug 1890. Although it Jean-Marc> is a satisfactory fix (insert the optarg ins

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Jean-Marc" == Jean-Marc Lasgouttes >> <[EMAIL PROTECTED]> writes: > > Jean-Marc> The following (trivial) patch fixes bug 1890. Although it > Jean-Marc> is a satisfactory fix (insert the optarg inset as open > Jean-Marc> instead of collapsed, like for all ot

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Angus Leeming
Martin Vermeer wrote: Martin> I would say there are two different real value pairs, as there Martin> are two insets within each other. The collapsable inset uses Martin> its own draw method, and the textinset inside it, its own. Martin> The fact that InsetCollapsable derives from InsetText is a

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Hmmm. This Martin> 43 InsetCollapsable::InsetCollapsable Martin> 44 (BufferParams const & bp, CollapseStatus status) Martin> 45 : InsetText(bp), label("Label"), status_(status), openinlined_(false) Marti

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Martin Vermeer
On Wed, 2005-06-01 at 16:08, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> I would say there are two different real value pairs, as there > Martin> are two insets within each other. The collapsable inset uses > Martin> its own draw method, a

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I would say there are two different real value pairs, as there Martin> are two insets within each other. The collapsable inset uses Martin> its own draw method, and the textinset inside it, its own. Martin> The fact that InsetCo

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Martin Vermeer
On Wed, 2005-06-01 at 15:44, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > Jean-Marc> The following (trivial) patch fixes bug 1890. Although it > Jean-Marc> is a satisfactory fix (insert the optarg inset as open > Jean-Marc> instead of coll

Re: [PATCH] bug 1890: insetoptarg triggers assertion

2005-06-01 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The following (trivial) patch fixes bug 1890. Although it Jean-Marc> is a satisfactory fix (insert the optarg inset as open Jean-Marc> instead of collapsed, like for all other collapsable Jean-Marc> insets), it hides

[PATCH] bug 1890: insetoptarg triggers assertion

2005-05-31 Thread Jean-Marc Lasgouttes
The following (trivial) patch fixes bug 1890. Although it is a satisfactory fix (insert the optarg inset as open instead of collapsed, like for all other collapsable insets), it hides a more annoying bug: when the collapsable inset is inserted as collapsed, the xo() and yo() values are not set cor