Re: [PATCH] a bit of getStatus reorganization

2008-05-23 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > I am doing the GuiApplication part. Good. JMarc

Re: [PATCH] a bit of getStatus reorganization

2008-05-23 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: On second thinking it should be fine. Only those LFUNs handled by GuiView should be affected so I think this is OK. Ack from me. Actually, I wanted to it now to avoid that new code like that appear in LyXFunc.

Re: [PATCH] a bit of getStatus reorganization

2008-05-23 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: > Jean-Marc Lasgouttes wrote: >> Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> >> > On second thinking it should be fine. Only those LFUNs handled by >> > GuiView should be affected so I think this is OK. >> > >> > Ack from me. >> >> Actually, I wanted

Re: [PATCH] a bit of getStatus reorganization

2008-05-22 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > On second thinking it should be fine. Only those LFUNs handled by > > GuiView should be affected so I think this is OK. > > > > Ack from me. > > Actually, I wanted to it now to avoid that new code like that appear >

Re: [PATCH] a bit of getStatus reorganization

2008-05-22 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > On second thinking it should be fine. Only those LFUNs handled by > GuiView should be affected so I think this is OK. > > Ack from me. Actually, I wanted to it now to avoid that new code like that appear in LyXFunc. Thanks. Applied. JMarc

Re: [PATCH] a bit of getStatus reorganization

2008-05-20 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: While investigating bug 4607 (that Abdel solved in the meantime), I came up with this patch to handle LyXView::getStatus. I post it here to insist on how things are supposed to work. LyXView::getStatus has been changed to return true if it has something to say, and fa

[PATCH] a bit of getStatus reorganization

2008-05-20 Thread Jean-Marc Lasgouttes
While investigating bug 4607 (that Abdel solved in the meantime), I came up with this patch to handle LyXView::getStatus. I post it here to insist on how things are supposed to work. LyXView::getStatus has been changed to return true if it has something to say, and false otherwise. This is how di