Asger Alstrup wrote:
> Martin Vermeer wrote:
>> See attached patch, which has been on the list for a few days.
>
> Technically, you posted the first version of this before the freeze was
> announced, so I think it's fair to put it in, also considering the number
> of revisions you have made.
Ple
Martin Vermeer wrote:
See attached patch, which has been on the list for a few days.
Technically, you posted the first version of this before the freeze was
announced, so I think it's fair to put it in, also considering the number
of revisions you have made.
Regards,
Asger
On Fri, Feb 11, 2005 at 09:42:28PM +0100, Andre Poenitz wrote:
> On Wed, Feb 09, 2005 at 11:15:40AM +0200, Martin Vermeer wrote:
> > What I meant is that the lines_ parameter in RowInfo only describes
> > hlines _above_ the row. If you see a simple fix, great.
>
> rowinfo_.size() == nrows() + 1
>
On Wed, Feb 09, 2005 at 11:15:40AM +0200, Martin Vermeer wrote:
> What I meant is that the lines_ parameter in RowInfo only describes
> hlines _above_ the row. If you see a simple fix, great.
rowinfo_.size() == nrows() + 1
> Actually I have no problem putting a hline above the first row, or
> out
On Thu, 2005-02-10 at 10:34, Georg Baum wrote:
...
> It would be nice if you could merge the attached patch with yours and commit
> it, because I don't have time to work on that right now.
>
>
> Georg
Done. Result attached. Works.
- Martin
Index: lib/ChangeLog
Martin Vermeer wrote:
> What does this do? I don't get it.
>
> if (!lyx::support::contains("tcb", cmd.argument[0])) {
> flag.enable(false);
> break;
> }
> flag.setOnOff(cmd.argument[0] == v_align_);
I
On Thu, 2005-02-10 at 10:34, Georg Baum wrote:
> Martin Vermeer wrote:
...
> It would be nice if you could merge the attached patch with yours and commit
> it, because I don't have time to work on that right now.
OK.
What does this do? I don't get it.
if (!lyx::support::contain
Martin Vermeer wrote:
> If I may summarize what I think it _should_ do:
>
> 1) If you want to swap two rows, make sure you're not on the last row.
No. If you are on the last row, it is swapped with the second to last one.
This is consistent with the tabular inset, so we should not change it.
>
On Wed, 2005-02-09 at 21:25, Martin Vermeer wrote:
> On Wed, 2005-02-09 at 09:00 +0100, Georg Baum wrote:
> > Martin Vermeer wrote:
>
> ...
>
> I checked in the basic patch, as it is very straightforward. We'll have
> to think about getStatus.
...
Try the attached on for size :-)
- Martin
In
On Wed, 2005-02-09 at 09:00 +0100, Georg Baum wrote:
> Martin Vermeer wrote:
...
I checked in the basic patch, as it is very straightforward. We'll have
to think about getStatus.
> >> And getStatus needs to be updated to disable addHLineAbove if the cursor
> >> is in the first row.
> >
> > How?
New patch, much simpler :-)
- Martin
Index: lib/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/lib/ChangeLog,v
retrieving revision 1.671
diff -u -r1.671 ChangeLog
--- lib/ChangeLog 8 Feb 2005 10:41:58 - 1.671
+++ lib/Cha
On Wed, 2005-02-09 at 10:00, Georg Baum wrote:
> Martin Vermeer wrote:
>
> > You're even righter than you think: these conditions are not needed when
> > you think about it, so I just removed all of them.
>
> Why are they not needed? I must be blind, but I don't see it. And if they
> are really n
Martin Vermeer wrote:
> You're even righter than you think: these conditions are not needed when
> you think about it, so I just removed all of them.
Why are they not needed? I must be blind, but I don't see it. And if they
are really not needed, then there is IMHO no need for the new methods at
On Tue, 2005-02-08 at 19:25 +0100, Georg Baum wrote:
> Martin Vermeer wrote:
>
> > +void MathGridInset::horLine(row_type row)
> > +{
> > +if (nrows() == 1)
> > +return;
> > +if (row + 1 == nrows())
> > +--row;
> > +rowinfo_[row].lines_++;
> >
Martin Vermeer wrote:
> +void MathGridInset::horLine(row_type row)
> +{
> +if (nrows() == 1)
> +return;
> +if (row + 1 == nrows())
> +--row;
> +rowinfo_[row].lines_++;
> +}
I don't understand this. I understand that this method adds a line a
Martin Vermeer <[EMAIL PROTECTED]> writes:
| On Tue, 2005-02-08 at 15:14, Lars Gullik Bjønnes wrote:
>> Martin Vermeer <[EMAIL PROTECTED]> writes:
>>
>> | +2005-02-08 Martin Vermeer <[EMAIL PROTECTED]>
>>
>> | +
>>
>> | + * math_gridinset.[hC]: add methods horLine, rmHorLine,
>>
>> | + v
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> What would you consider legible? delHorLine?
Martin> deleteHorizontalLineAbove? I'm happy to please :-)
I would say delete is better than rm because we use that term. And we
use HLine too in tabular. So I would propose deleteHLi
On Tue, 2005-02-08 at 15:14, Lars Gullik BjÃnnes wrote:
> Martin Vermeer <[EMAIL PROTECTED]> writes:
>
> | +2005-02-08 Martin Vermeer <[EMAIL PROTECTED]>
>
> | +
>
> | + * math_gridinset.[hC]: add methods horLine, rmHorLine,
>
> | + vertLine, rmVertLine for drawing/deleting partition lin
Martin Vermeer <[EMAIL PROTECTED]> writes:
| +2005-02-08 Martin Vermeer <[EMAIL PROTECTED]>
| +
| + * math_gridinset.[hC]: add methods horLine, rmHorLine,
| + vertLine, rmVertLine for drawing/deleting partition lines
| + in matrix
Please use less cryptic names. Spell it out.
Here is the patch to add a user interface to this facility. It allows
both the drawing and the erasure of both horizontal and vertical
partition lines in math matrices, straight from the math edit menu.
As this cleanly fixes a fatal useability/discoverability bug of an
already fully implemented fa
20 matches
Mail list logo
