Re: [PATCH] Subversion support

2005-06-12 Thread Lars Gullik Bjønnes
Baruch Even <[EMAIL PROTECTED]> writes: | More comments integrated. > | escaping stolen from PHP4, And done without ' or ". > | Someone should test this under Windows, I don't think it really works | there, but I can't test. I think we should wait with this patch for 1.5. - Put it in 1.5 first,

Re: [PATCH] Subversion support

2005-06-11 Thread Andre Poenitz
On Wed, Jun 08, 2005 at 07:31:06PM +0200, Lars Gullik Bjønnes wrote: > | +SVN::SVN(string const & f) > | +{ > | + file_ = f; > | + scanMaster(); > | + vcstatus = UNLOCKED; // There is no locked state for > | +Subversion > > Doesn't the newest version have some support for locks? Indeed. 1.2

Re: [PATCH] Subversion support

2005-06-09 Thread Baruch Even
Georg Baum wrote: > > Baruch Even wrote: > > >>Someone should test this under Windows, I don't think it really works >>there, but I can't test. > > > CVS does probably not work there. You'll need to replace > > doVCCommand("rm -f " + fil + "; cvs update " + fil, > owne

Re: [PATCH] Subversion support

2005-06-09 Thread Georg Baum
Baruch Even wrote: > Someone should test this under Windows, I don't think it really works > there, but I can't test. CVS does probably not work there. You'll need to replace doVCCommand("rm -f " + fil + "; cvs update " + fil, owner_->filePath()); with something like

Re: [PATCH] Subversion support

2005-06-08 Thread Baruch Even
More comments integrated. escaping stolen from PHP4, And done without ' or ". Someone should test this under Windows, I don't think it really works there, but I can't test. Baruch Baruch Even wrote: > Baruch Even wrote: > >>p.s. I'm not subscribed, please CC me on correspondence. Thanks! > >

Re: [PATCH] Subversion support

2005-06-08 Thread Lars Gullik Bjønnes
Baruch Even <[EMAIL PROTECTED]> writes: | +void SVN::scanMaster(void) | +{ | + cmd_ret const ret = RunSVNInfo(file_); | + string buffer = ret.second; | + string head; | + bool found = false; | + | + while (buffer.length() > 0) { while (!buffer.empty()) { is better. | +void S

Re: [PATCH] Subversion support

2005-06-08 Thread Lars Gullik Bjønnes
Baruch Even <[EMAIL PROTECTED]> writes: | Baruch Even wrote: >> p.s. I'm not subscribed, please CC me on correspondence. Thanks! > | Either the mail was eaten by the mail-server or I was ignored. gmane | sucks since I can't get it to send the e-mail to my favourite e-mail | program of the day. He

Re: [PATCH] Subversion support

2005-06-08 Thread Baruch Even
Forgot to attach. This time it is attached. Baruch Baruch Even wrote: > Baruch Even wrote: > >>p.s. I'm not subscribed, please CC me on correspondence. Thanks! > > > Either the mail was eaten by the mail-server or I was ignored. gmane > sucks since I can't get it to send the e-mail to my favou

Re: [PATCH] Subversion support

2005-06-08 Thread Baruch Even
Baruch Even wrote: > p.s. I'm not subscribed, please CC me on correspondence. Thanks! Either the mail was eaten by the mail-server or I was ignored. gmane sucks since I can't get it to send the e-mail to my favourite e-mail program of the day. I fixed most of the comments and attached the updated

Re: [PATCH] Subversion support

2005-06-08 Thread Lars Gullik Bjønnes
Baruch Even <[EMAIL PROTECTED]> writes: | Hi, > | Since I've started to use LyX again (doing an M.Sc. in CS in Ireland) I | thought I'd scratch and itch. > | Attached is a patch to add Subversion support to the Version Control system. I'll have close look on this one. | Unlike CVS I'm not trying

[PATCH] Subversion support

2005-06-08 Thread Baruch Even
Hi, Since I've started to use LyX again (doing an M.Sc. in CS in Ireland) I thought I'd scratch and itch. Attached is a patch to add Subversion support to the Version Control system. Unlike CVS I'm not trying to parse .svn/entries, it's XML and I'm not sure I want to deal with it at all. I'm sim