Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-24 Thread Abdelrazak Younes
José Matos wrote: On Wednesday 22 August 2007 13:40:09 Abdelrazak Younes wrote: Jose, do you want me to proceed? Yes. Please coordinate with Bo since this is his code. I've committed it. Abdel. Author: younes Date: Fri Aug 24 15:53:45 2007 New Revision: 19770 URL: http://www.lyx.org/tr

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-23 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Thu, Aug 23, 2007 at 01:05:27PM +0200, Alfredo Braunstein wrote: >> >> >> >> 2) one idea would be to use a special mark inset. This would solve b) >> >> but not a). Aditionally, this implies that we have an undesired object >> >> that obstacles edition. We could try to t

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-23 Thread Andre Poenitz
On Thu, Aug 23, 2007 at 01:05:27PM +0200, Alfredo Braunstein wrote: > >> > >> 2) one idea would be to use a special mark inset. This would solve b) but > >> not a). Aditionally, this implies that we have an undesired object that > >> obstacles edition. We could try to track its existence with a si

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-23 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Wed, Aug 22, 2007 at 04:55:13PM +0200, Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >> > Alfredo Braunstein wrote: >> >> Abdelrazak Younes wrote: >> >> >> >>> Well, at runtime, in-inset bookmark sort of work now because we >> >>> already use the paragraph id

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
José Matos wrote: On Wednesday 22 August 2007 16:04:08 Abdelrazak Younes wrote: I guess I am talking about this bug: http://bugzilla.lyx.org/show_bug.cgi?id=3171 This bug is irrelevant now that we have one BufferView per Buffer ;-) If that is the case then please mark the bug as fixedintrun

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Bo Peng wrote: Bo, is that OK for you? Sorry Bo, I did not wait because my fix to bug 3427 needed this one. I hope you don't mind, this is just cosmetics (apart for the font bug fixing). Test 3171 and see if you need to re-open that bug. I tested it and found no problem. But I did not expect

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Andre Poenitz
On Wed, Aug 22, 2007 at 07:14:37PM +0100, José Matos wrote: > On Wednesday 22 August 2007 18:52:25 Alfredo Braunstein wrote: > > Care to explain? > > Actually I don't remember much and google is not friend. :-) > > If every paragraph (and insets fwiw) had an universal unique ID the > bookmar

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Andre Poenitz
On Wed, Aug 22, 2007 at 04:55:13PM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > > Alfredo Braunstein wrote: > >> Abdelrazak Younes wrote: > >> > >>> Well, at runtime, in-inset bookmark sort of work now because we already > >>> use the paragraph id. What is missing is the saving

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Alfredo Braunstein
José Matos wrote: > On Wednesday 22 August 2007 18:52:25 Alfredo Braunstein wrote: >> Care to explain? > > Actually I don't remember much and google is not friend. :-) > > If every paragraph (and insets fwiw) had an universal unique ID the > bookmarks would be a lot more stable, no? I don't

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread José Matos
On Wednesday 22 August 2007 18:52:25 Alfredo Braunstein wrote: > Care to explain? Actually I don't remember much and google is not friend. :-) If every paragraph (and insets fwiw) had an universal unique ID the bookmarks would be a lot more stable, no? > A/ -- José Abílio

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Alfredo Braunstein
José Matos wrote: > On Wednesday 22 August 2007 15:13:27 Alfredo Braunstein wrote: >> But Stable/DocIterators are not edit-persistent (you need some kind of >> registering with the buffer to adjust on user edition). Do you have some >> ideas? > > We have used before the idea of using libuuid (u

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Bo Peng
> Yes. Please coordinate with Bo since this is his code. I am keeping an eye on this, while preparing embedding patch two. Bo

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread José Matos
On Wednesday 22 August 2007 13:40:09 Abdelrazak Younes wrote: > Jose, do you want me to proceed? Yes. Please coordinate with Bo since this is his code. > Abdel. -- José Abílio

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread José Matos
On Wednesday 22 August 2007 15:13:27 Alfredo Braunstein wrote: > But Stable/DocIterators are not edit-persistent (you need some kind of > registering with the buffer to adjust on user edition). Do you have some > ideas? We have used before the idea of using libuuid (universally unique identifie

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread José Matos
On Wednesday 22 August 2007 16:04:08 Abdelrazak Younes wrote: > > I guess I am talking about this bug: > > http://bugzilla.lyx.org/show_bug.cgi?id=3171 > > This bug is irrelevant now that we have one BufferView per Buffer ;-) If that is the case then please mark the bug as fixedintrunk. :-) > A

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Martin Vermeer
On Wed, 22 Aug 2007 09:46:59 -0500 Bo Peng <[EMAIL PROTECTED]> wrote: > > There is a dirty trick used in the handling of bookmarks: bookmark id > > needs to be converted to pit because only the latter can be saved in > > session. Therefore, moveToPosition is called when a buffer is closed > > and

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Bo Peng
> > Bo, is that OK for you? > > Sorry Bo, I did not wait because my fix to bug 3427 needed this one. I > hope you don't mind, this is just cosmetics (apart for the font bug fixing). Test 3171 and see if you need to re-open that bug. Bo

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Bo Peng wrote: I am going to work a bit on the bookmark handling if you don't mind (see patch). The goal is to extend it to support in-inset bookmarks. Bo, is that OK for you? If I understand your patch correctly, you move cursor inside moveToPosition, instead of returning a new position. No

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> Well, at runtime, in-inset bookmark sort of work now because we already >>> use the paragraph id. What is missing is the saving/loading of in-inset >>> bookmark when a document is opened/closed. >> >> I see (

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Bo Peng
> There is a dirty trick used in the handling of bookmarks: bookmark id > needs to be converted to pit because only the latter can be saved in > session. Therefore, moveToPosition is called when a buffer is closed > and switched, and we DO not want to move the cursor in this cases, > especially for

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Bo Peng
> I am going to work a bit on the bookmark handling if you don't mind (see > patch). The goal is to extend it to support in-inset bookmarks. > > Bo, is that OK for you? If I understand your patch correctly, you move cursor inside moveToPosition, instead of returning a new position. There is a dir

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Well, at runtime, in-inset bookmark sort of work now because we already use the paragraph id. What is missing is the saving/loading of in-inset bookmark when a document is opened/closed. I see (missed the point) :-) Still, you are welcome t

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello there, I am going to work a bit on the bookmark handling if you don't mind (see patch). The goal is to extend it to support in-inset bookmarks. Bo, is that OK for you? Sorry Bo, I did not wait because my fix to bug 3427 needed this one. I hope you don't mind,

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Well, at runtime, in-inset bookmark sort of work now because we already > use the paragraph id. What is missing is the saving/loading of in-inset > bookmark when a document is opened/closed. I see (missed the point) :-) A/

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: I am going to work a bit on the bookmark handling if you don't mind (see patch). The goal is to extend it to support in-inset bookmarks. Bo, is that OK for you? I'm not Bo, but I don't like this approach actually. Which approach? I am just c

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >>> I am going to work a bit on the bookmark handling if you don't mind (see >>> patch). The goal is to extend it to support in-inset bookmarks. >>> >>> Bo, is that OK for you? >> >> I'm not Bo, but I don't like this approach actually. > > Which approach? I am just clean

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Hello there, I am going to work a bit on the bookmark handling if you don't mind (see patch). The goal is to extend it to support in-inset bookmarks. Bo, is that OK for you? I'm not Bo, but I don't like this approach actually. Which appro

Re: [PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Hello there, > > I am going to work a bit on the bookmark handling if you don't mind (see > patch). The goal is to extend it to support in-inset bookmarks. > > Bo, is that OK for you? I'm not Bo, but I don't like this approach actually. IMHO, we should think harder in

[PATCH] Simplify bookmars handling and further improvments...

2007-08-22 Thread Abdelrazak Younes
Hello there, I am going to work a bit on the bookmark handling if you don't mind (see patch). The goal is to extend it to support in-inset bookmarks. Bo, is that OK for you? There is by the way a bug in 1.5.x with bookmarks: the current font is not set. Putting this line at the end of Buffer