Re: [PATCH] Re: case mismatch in citation dialog

2007-04-22 Thread Richard Heck
José Matos wrote: > On Saturday 21 April 2007 11:30:40 am Michael Gerz wrote: > >> Has this been fixed in the meantime? Maybe I missed an svn commit... >> > No. I asked Richard to wait for beta-2 release, the patch will go after. > > At least that is my understanding. :-) > Yes, and

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-21 Thread Bernhard Roider
i was off for a week... Richard Heck wrote: This turns out not to matter, as entryDelim must be a leftover from some previous code: ... this is correct indeed. Bernhard Richard Abdelrazak Younes wrote: Richard Heck wrote: And oh by the way, can someone check this bit: if

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-21 Thread José Matos
On Saturday 21 April 2007 11:30:40 am Michael Gerz wrote: > > Has this been fixed in the meantime? Maybe I missed an svn commit... No. I asked Richard to wait for beta-2 release, the patch will go after. At least that is my understanding. :-) > Michael -- José Abílio

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-21 Thread Michael Gerz
Abdelrazak Younes schrieb: Richard Heck wrote: And oh by the way, can someone check this bit: if (ch == '(') entryDelim = ')'; -else if (ch == '{') entryDelim = ')'; +else if (ch == '{') entryDelim = '}'; It had previous been: else if (ch = '{') entryDe

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-19 Thread Richard Heck
This turns out not to matter, as entryDelim must be a leftover from some previous code: It's set but never read---which is why no problem ever occurred here---so it can just be deleted.But I'll wait a bit before committing, in case Bernhard has a different view. Richard Abdelrazak Younes wrote:

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-19 Thread Abdelrazak Younes
Richard Heck wrote: And oh by the way, can someone check this bit: if (ch == '(') entryDelim = ')'; - else if (ch == '{') entryDelim = ')'; + else if (ch == '{') entryDelim = '}'; It had previous been: else if (ch = '{') en

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Edwin Leuven
Richard Heck wrote: The cause of the problem here is in the new BibTeX parser. The attached patch seems to solve this issue. Comments welcome. works for me, thanks! And see? This time it really is attached. and amazingly fast (sure you're sick? ;-)

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
Sorry for all the mail. Come to notice, in fact entryDelim is never read. So this can probably go. Richard Richard Heck wrote: > And oh by the way, can someone check this bit: > > >> if (ch == '(') entryDelim = ')'; >> -else if (ch == '{') entryDelim

Re: [PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
And oh by the way, can someone check this bit: > if (ch == '(') entryDelim = ')'; > - else if (ch == '{') entryDelim = ')'; > + else if (ch == '{') entryDelim = '}'; > It had previous been: else if (ch = '{') entryDelim = ')'. That'

[PATCH] Re: case mismatch in citation dialog

2007-04-18 Thread Richard Heck
Edwin Leuven wrote: > Richard Heck wrote: >> Everything seems to have gone lowercase there, and in the output, though >> that seems to work nonetheless. Odd that. > 1.4 preserves case when saving. loading such a document now gives me > the problem. > > i think bibtex ignores case in the keys but i