> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> I think I see what you mean. OK, so let it return an InsetBase, but
>> rename the method to something like realInset().
Juergen> The attached patch works for me.
Put it in, then.
JMarc
Jean-Marc Lasgouttes wrote:
> I think I see what you mean. OK, so let it return an InsetBase, but
> rename the method to something like realInset().
The attached patch works for me.
Jürgen
Index: dociterator.C
===
RCS file: /usr/loca
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: Then I have to convert it back to
Juergen> InsetBase in undo.C to pass it to setInsetOwner. How can I do
Juergen> this?
>> Why do you need that? Doesn't InsetText derive from InsetBase?
Juerg
Jean-Marc Lasgouttes wrote:
> Juergen> Then I have to convert it back to InsetBase in undo.C to pass
> Juergen> it to setInsetOwner. How can I do this?
>
> Why do you need that? Doesn't InsetText derive from InsetBase?
I just can't get it to compile. Attached is what I have now.
Or do you mean I s
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> 1/ make textInset return an InsetText object; Assert on inTexted()
Juergen> Then I have to convert it back to InsetBase in undo.C to pass
Juergen> it to setInsetOwner. How can I do this?
W
Jean-Marc Lasgouttes wrote:
> 1/ make textInset return an InsetText object; Assert on inTexted()
Then I have to convert it back to InsetBase in undo.C to pass it to
setInsetOwner. How can I do this?
> 2/ the loop in undo.C should use normal iterators instead of
> const_iterators, so that the con
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> At least, you could move your code that determines what the real
>> text inset is into dociterator.C.
Juergen> is attached.
Almost perfect :
1/ make textInset return an InsetText object;
Jean-Marc Lasgouttes wrote:
> At least, you could move your code that determines what the real text
> inset is into dociterator.C.
is attached.
Jürgen
Index: dociterator.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/dociterato
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: What about this?
>> What about hiding part of this code in a Dociterator::textInset
>> method? It could either be the current ugly special code, or use a
>> new InsetText * InsetBase::getCel
Jean-Marc Lasgouttes wrote:
> Juergen> What about this?
>
> What about hiding part of this code in a Dociterator::textInset
> method? It could either be the current ugly special code, or use a new
> InsetText * InsetBase::getCell(int) const;
> that could maybe replace InsetBase::getText(int).
I
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Juergen Spitzmueller wrote:
>> The attached patch fixes bug 1952 for me. Some additional testing
>> would be nice, though.
Juergen> What about this?
What about hiding part of this code in a Dociterator::textInset
method
Am Donnerstag, 17. November 2005 09:43 schrieb Juergen Spitzmueller:
> Juergen Spitzmueller wrote:
> > The attached patch fixes bug 1952 for me. Some additional testing
> > would be nice, though.
>
> What about this?
works for me.
Georg
Juergen Spitzmueller wrote:
> The attached patch fixes bug 1952 for me. Some additional testing
> would be nice, though.
What about this?
Georg Baum wrote:
> I believe that the cursor can never go into a single cell of a tabluar,
> only in a tabular as a whole. The cells are addressed via LCursor::idx().
> Therefore dit.inset() returns the tabular inset, and not the cell.
Thanks for the explanation, Georg. I modified your code a bit
14 matches
Mail list logo
