Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-23 Thread Helge Hafting
Bo Peng wrote: Sure it can, one time I had a command sequence that launched LyX, opened the UserGuide, scrolled it to the end, and exit LyX at the end. You can put any LFUN in this command-sequence. and check if lyx crashes, Surely a test program can be made to notice that LyX crashes. Or at

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
Sure it can, one time I had a command sequence that launched LyX, opened the UserGuide, scrolled it to the end, and exit LyX at the end. You can put any LFUN in this command-sequence. and check if lyx crashes, and if the pasted text is what you cut? I guess the long term goal (?) is having eithe

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: LyX can be scripted too thanks to the LFUNs... Then we need to write a bunch of scripts to convert back and forth, move, select, cut, paste, save/load, new/close window although I do not think lyx can be manipulated like that externally. Sure it can, one time I had a comma

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
LyX can be scripted too thanks to the LFUNs... Then we need to write a bunch of scripts to convert back and forth, move, select, cut, paste, save/load, new/close window although I do not think lyx can be manipulated like that externally. Bo

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: On 7/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Abdelrazak Younes wrote: > No, my patch is the right fix and I am responsible for this: in rev > 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-)

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Bo Peng wrote: Just let me the time to switch my repository to trunk :-) Just to confirm that your patch works. Please put it in. It's in already :-) Abdel.

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
Just let me the time to switch my repository to trunk :-) Just to confirm that your patch works. Please put it in. Bo

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
On 7/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Abdelrazak Younes wrote: > No, my patch is the right fix and I am responsible for this: in rev > 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-) This makes me

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: No, my patch is the right fix and I am responsible for this: in rev 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-) Just let me the time to switch my repository to

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
> fix attached. No, my patch is the right fix and I am responsible for this: in rev 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). I produced exactly the same patch (5s later than you :-) ... please commit if it works. Cheers, Bo

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > No, my patch is the right fix and I am responsible for this: in rev > 19040, I eagerly erased two lines (++cur.pit() and --cur.pit()). Well, then put it in again, before I'll release the dogs ;-) Jürgen

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Bo Peng wrote: Open the attached lyx file, move cursor to the end of the second line (actually anywhere with pos > length of previous line). Edit -> paragraph up, lyx crashes. fix attached. No, my patch is the right fix and I am responsible for this: in rev 19040,

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Bo Peng wrote: > > fix attached. > > This fixes the crash but I think the correct behavior should be > keeping the cursor in its original paragraph and location, right? That would be Abdel's patch. Jürgen

[PATCH] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Obvious candidates for the brown paper bag: http://www.lyx.org/trac/changeset/19057 Unlikely (this affects only LaTeX output). http://www.lyx.org/trac/changeset/19046 Reverting this does not fix the crash. I was wrong, see my other post

Re: [patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Bo Peng
On 7/13/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Bo Peng wrote: > Open the attached lyx file, move cursor to the end of the second line > (actually anywhere with pos > length of previous line). Edit -> > paragraph up, lyx crashes. fix attached. This fixes the crash but I think the cor

[patch] Re: Lyx crashes with paragraph up.

2007-07-13 Thread Jürgen Spitzmüller
Bo Peng wrote: > Open the attached lyx file, move cursor to the end of the second line > (actually anywhere with pos > length of previous line). Edit -> > paragraph up, lyx crashes. fix attached. Jürgen Index: src/Text3.cpp === --- s