Re: [PATCH] qcitation fixes

2004-02-18 Thread Juergen Spitzmueller
Andre Poenitz wrote: > Using trailing underscores in member variable names is encouraged in > LyX... Ill_fix_that_ Jürgen

Re: [PATCH] qcitation fixes

2004-02-18 Thread Andre Poenitz
Using trailing underscores in member variable names is encouraged in LyX... Andre'

Re: [PATCH] qcitation fixes

2004-02-18 Thread Juergen Spitzmueller
Angus Leeming wrote: > Add a boolean flag "open_find_automatically" to the > QCitation class, setting it to "true" in the constructor and in > QCitation::hide. Perfect, Angus. Many thanks. Can I apply the attached patch? It works as expected. Regards, Jürgen. Index: src/frontends/qt2/QCitation.C

Re: [PATCH] qcitation fixes

2004-02-17 Thread Angus Leeming
Juergen Spitzmueller wrote: > He has. He has selected one or more new entries from the database. > But he cannot apply them, although they show up in the "selected" > browser. That's the problem. (I agree that the more elegant solution > would be not to open find after apply. But I don't know how t

Re: [PATCH] qcitation fixes

2004-02-17 Thread Juergen Spitzmueller
Angus Leeming wrote: > No it doesn't. You can Apply to an existing inset. > > What it does do is disconnect from any existing inset so subsequently > pressing Apply will create a new inset. Yes, that's what I meant. > > IMO this behaviour is ok because you have to open > > that dialog anyway (the

Re: [PATCH] qcitation fixes

2004-02-17 Thread Angus Leeming
Juergen Spitzmueller wrote: >> Incidentally, I don't understand why the find dialog is opened when >> the user presses Apply in the main dialog. That feels very ugly to >> me. > > It is because it also creates a new citation inset No it doesn't. You can Apply to an existing inset. What it does d

Re: [PATCH] qcitation fixes

2004-02-17 Thread Juergen Spitzmueller
Angus Leeming wrote: > When you press Apply, you execute this code. So, I think that the > behaviour you describe is to be expected. I see. Anything I can do about that? > Incidentally, I don't understand why the find dialog is opened when > the user presses Apply in the main dialog. That feels v

Re: [PATCH] qcitation fixes

2004-02-17 Thread Angus Leeming
Juergen Spitzmueller wrote: > It works nicely, except for one thing: after applying (pressing > apply, not ok) the find dialog is also opened (which is o.k.), but > the bc().valid() call is not recognized: the buttons stay disabled. > Any idea on this? When you press Apply, you execute this code.

[PATCH] qcitation fixes

2004-02-17 Thread Juergen Spitzmueller
The patch tries to fix (the rest of) bug 1146 http://bugzilla.lyx.org/show_bug.cgi?id=1146 It always opens the find dialog if a new citation inset is being inserted (and thus saves a few annoying keypresses). Can some kind soul please review? It works nicely, except for one thing: after applying

Re: [PATCH] QCitation fixes

2003-07-20 Thread John Levon
On Wed, Jul 16, 2003 at 11:37:57AM +0200, Juergen Spitzmueller wrote: > - allow multiple selections in the add browser > - prohibit duplicate insertions OK to apply. Sorry for the delay. > I'd like to add this functionality also to the bibtex dialog. > OK to apply (also, if identical, for qbibte

Re: [PATCH] QCitation fixes

2003-07-18 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Some of the stuff discussed before (bug 1146): > > - allow multiple selections in the add browser > - prohibit duplicate insertions > > I'd like to add this functionality also to the bibtex dialog. > OK to apply (also, if identical, for qbibtex)? ?? Juergen.

[PATCH] QCitation fixes

2003-07-16 Thread Juergen Spitzmueller
Some of the stuff discussed before (bug 1146): - allow multiple selections in the add browser - prohibit duplicate insertions I'd like to add this functionality also to the bibtex dialog. OK to apply (also, if identical, for qbibtex)? Juergen PS: Still todo is the immidiate opening of the add d