Am Montag, 29. Dezember 2003 16:16 schrieb Angus Leeming:
> What I meant was that this 'removal of InsetMinipage/conversion of
> InsetMinipage to InsetBox' is a format change and so should
> 1 be documented
> 2 be placed in its own lyx2lyx files, lyxconvert_228.py and
> lyxrevert_229.py.
'removal
Angus Leeming wrote:
> > Is the attached better?
>
> My opinion?
If you are in the mood...
> Yes.
OK, then I apply this and hope to close the chapter "minipage insets" finally.
Jürgen.
Juergen Spitzmueller wrote:
>> The bare bones lyxconvert_228.py and lyxrevert_229.py are pointless
>> (as you say). Personally I'd move the conversion code into them.
>> The more of these tiny files we have, the more likely José is to
>> come up with a versioning system that separates file from for
Angus Leeming wrote:
> What I meant was that this 'removal of InsetMinipage/conversion of
> InsetMinipage to InsetBox' is a format change and so should
> 1 be documented
> 2 be placed in its own lyx2lyx files, lyxconvert_228.py and
> lyxrevert_229.py.
Yes, this is certainly much cleaner.
> The ba
Juergen Spitzmueller wrote:
> Angus Leeming wrote:
>> Could you increase the LyX format by one please (src/buffer.C) and
>> add a note to this effect in development/FORMAT. To that end, it
>> would probably be best to create new lyxconvert/lyxrevert files
>> too...
>
> I don't quite understand wh
Angus Leeming wrote:
> Could you increase the LyX format by one please (src/buffer.C) and add
> a note to this effect in development/FORMAT. To that end, it would
> probably be best to create new lyxconvert/lyxrevert files too...
I don't quite understand why this is necessary here, but anyway. Can
Angus Leeming wrote:
> Juergen Spitzmueller wrote:
>> IMHO Michael's patch could go in now. Can I apply it?
>
> Go for it.
I see you did indeed go for it.
Could you increase the LyX format by one please (src/buffer.C) and add
a note to this effect in development/FORMAT. To that end, it would
Juergen Spitzmueller wrote:
> IMHO Michael's patch could go in now. Can I apply it?
Go for it.
--
Angus
Jose' Matos wrote:
> The code look correct and all the individual converter are self-contained.
> The only thing that could go wrong is come missing import statement, but
> those seem ok.
>
> Does it works?
Yes. It works on Kornel's test file.
> If yes then apply it. :-)
Done. Thanks.
IMHO M
On Monday 29 December 2003 11:20, Juergen Spitzmueller wrote:
> Angus Leeming wrote:
> > My opinion? Move it.
>
> I do not much understand lyx2lyx. Is the attached correct?
The code look correct and all the individual converter are self-contained.
The only thing that could go wrong is come miss
Angus Leeming wrote:
> My opinion? Move it.
I do not much understand lyx2lyx. Is the attached correct?
Jürgen.
Index: lyxconvert_224.py
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/lib/lyx2lyx/lyxconvert_224.py,v
retrieving revisio
Juergen Spitzmueller wrote:
> about bleeding edge file formats or not? (the slution would be easy,
> as proposed by Angus: just move the conversion from
> lyxconvert_224.py to lyxconvert_227.py).
My opinion? Move it.
--
Angus
Michael Schmitt wrote:
> Hm... I think there _is_ a minipage->box conversion available in
> lyxconvert_224.py. Loading a LyX 1.3.4 document works as expected, at
> least. So what exactly is missing?
OK, short summary: The problem is that the minipage->box conversion happens
from 223->224 whil
Michael Schmitt wrote:
Juergen Spitzmueller wrote:
I think this can go in. Don't know what Angus' current plans about
moving the minipage->box conversion from 225 to 228 are, though. So
I'd wait for his vote.
If all this patch does is prevent new Miniboxes being created, then
great. Of course I
On Mon, Dec 22, 2003 at 03:58:52PM +0100, Michael Schmitt spake thusly:
> Enclosed please find a slightly modified patch again the current HEAD
> that "improves" the button label for boxes (the text "parbox" or
> "minipage" alone is a bit misleading UI-wise, especially as you may
> think that m
Juergen Spitzmueller wrote:
I think this can go in. Don't know what Angus' current plans about
moving the minipage->box conversion from 225 to 228 are, though. So
I'd wait for his vote.
If all this patch does is prevent new Miniboxes being created, then
great. Of course I vote for it to go in. Ho
Juergen Spitzmueller wrote:
> Michael Schmitt wrote:
>> already on vacation?
>
> not yet. but I'm packing my bags :-)
>
>> What happened to my patch that removes LFUN_INSET_MINIPAGE and some
>> other unused cruft? I did not follow the discussion in details.
>> What needs to be done to commit thi
Michael Schmitt wrote:
> already on vacation?
not yet. but I'm packing my bags :-)
> What happened to my patch that removes LFUN_INSET_MINIPAGE and some
> other unused cruft? I did not follow the discussion in details. What
> needs to be done to commit this patch?
I think this can go in. Don't k
Hello everybody,
already on vacation?
What happened to my patch that removes LFUN_INSET_MINIPAGE and some
other unused cruft? I did not follow the discussion in details. What
needs to be done to commit this patch?
Anyway, here it comes again.
Regards from snowless Bitburg, Germany,
Michael
I
Kornel Benko wrote:
> can live with this. Nonetheless it was still possible to insert
> such a minipage in current CVS (without your patch of course)
>
> Function "minipage-insert".
Yes. And that should not be possible in lyxformat 225. This is a bug IMHO.
Jürgen.
Georg Baum wrote:
> Try it: Current LyX without your patch can read the minipages that tex2lyx
> currently produces (although they cannot be inserted via menu anymore).
Sure. But eventually minipage will disappear, and then the problem will arise
anyway (unless lyx2lyx converts those rest-minipag
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 6. Dezember 2003 22:19, Georg Baum wrote:
> Am Samstag, 6. Dezember 2003 17:48 schrieb Juergen Spitzmueller:
> > Georg Baum wrote:
> > > Yes please, until tex2lyx is adapted to output the box inset instead of
> > > minipage.
> >
> > Hm, my patch does
Am Samstag, 6. Dezember 2003 17:48 schrieb Juergen Spitzmueller:
> Georg Baum wrote:
> > Yes please, until tex2lyx is adapted to output the box inset instead of
> > minipage.
>
> Hm, my patch does not make anything worse. tex2lyx produces \lyxformat
> 225 files, while lyx2lyx's minipage->box conver
Am Samstag, 6. Dezember 2003 15:36 schrieb Juergen Spitzmueller:
> BTW what is the status of lyx2lyx in this regard? Do we need another file
> format change?
We would have needed one when the box inset and the other changes were
introduced. Now it is too late, because we have already several "fla
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 6. Dezember 2003 16:33, Juergen Spitzmueller wrote:
> Kornel Benko wrote:
> > This minipage example is a left over of previous lyx-1.4cvs versions.
>
> OK, your file has \lyxformat 225, while the Minipage->(Frameless) Boxes
> conversion is 223 -> 22
Juergen Spitzmueller wrote:
> BTW what is the status of lyx2lyx in this regard? Do we need another file
> format change?
I found it.
Jürgen
Georg Baum wrote:
> Yes please, until tex2lyx is adapted to output the box inset instead of
> minipage.
Hm, my patch does not make anything worse. tex2lyx produces \lyxformat 225
files, while lyx2lyx's minipage->box conversion happens between 223 and 225.
So files with minipages produced with th
Juergen Spitzmueller wrote:
> Minipage.lyx, however, is read in with a wrong width value, but this is the
> same in 1.3.4. Minipage.lyx uses width="45p%", which is not valid anymore
> (lyx2lyx issue?).
This is where this changed btw:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/
lengthcomm
Kornel Benko wrote:
> This minipage example is a left over of previous lyx-1.4cvs versions.
OK, your file has \lyxformat 225, while the Minipage->(Frameless) Boxes
conversion is 223 -> 225. I'd say this is a bleeding edge result where I'd
leave you on your own. If you change \lyxformat to 223, t
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 6. Dezember 2003 15:51, Juergen Spitzmueller wrote:
> Kornel Benko wrote:
> > With this patch, the minipages are read in as "boxed".
> > Also the width of this inset is changed to 100 col%. (With the
> > CVS-Version the value is 70 col%)
> >
> > Shoul
Kornel Benko wrote:
> With this patch, the minipages are read in as "boxed".
> Also the width of this inset is changed to 100 col%. (With the
> CVS-Version the value is 70 col%)
>
> Should I try to provide a test-file?
Yes please. I cannot reproduce. Here, a minipage from an 1.3.4 file with
width
Georg Baum wrote:
> (or should we wait a bit)?
>
> Yes please, until tex2lyx is adapted to output the box inset instead of
> minipage.
ok.
BTW what is the status of lyx2lyx in this regard? Do we need another file
format change?
Jürgen.
Juergen Spitzmueller wrote:
> One for Angus...
> Now that the box inset superceeded minipage, it can theoretically be
> removed (or should we wait a bit)?
Yes please, until tex2lyx is adapted to output the box inset instead of
minipage.
Georg
-BEGIN PGP SIGNED MESSAGE-
On Samstag, 6. Dezember 2003 12:26, Juergen Spitzmueller wrote:
> One for Angus...
> Now that the box inset superceeded minipage, it can theoretically be removed
> (or should we wait a bit)?
With this patch, the minipages are read in as "boxed".
Also the width
One for Angus...
Now that the box inset superceeded minipage, it can theoretically be removed
(or should we wait a bit)?
Jürgen.
minipage.diff.gz
Description: GNU Zip compressed data
35 matches
Mail list logo
