Re: [PATCH] Making InsetCharStyle less prominent.

2007-11-29 Thread Andre Poenitz
On Sun, Oct 14, 2007 at 12:05:26PM -0700, Angus Leeming wrote: > Bo Peng wrote: >>> It's OK. But why did you delete the // FIXME UNICODE? >> By accident. Fixed and committed. >> Anyway, what is this 'FIXME UNICODE'? They are everywhere and nobody >> seems to be fixing them now. > > They refer to st

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Andre Poenitz
On Sun, Oct 14, 2007 at 11:33:52AM -0500, Bo Peng wrote: > > It's OK. But why did you delete the // FIXME UNICODE? > > By accident. Fixed and committed. > > Anyway, what is this 'FIXME UNICODE'? They are everywhere and nobody > seems to be fixing them now. I usually do when I bump into one. And

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Angus Leeming
Bo Peng wrote: It's OK. But why did you delete the // FIXME UNICODE? By accident. Fixed and committed. Anyway, what is this 'FIXME UNICODE'? They are everywhere and nobody seems to be fixing them now. They refer to string data in UTF-8 format that is being manipulated in some way. An exampl

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Martin Vermeer
On Sun, Oct 14, 2007 at 11:34:57AM -0500, Bo Peng wrote: > > > > This seems like a good idea. Would this go for trunk as well? > > I could not find InsetCharStyle in the trunk. Is it removed? > > Bo It's called InsetFlex (which covers Custom insets in addition to CharStyles) ... but this feature

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Bo Peng
> > This seems like a good idea. Would this go for trunk as well? I could not find InsetCharStyle in the trunk. Is it removed? Bo

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Bo Peng
> It's OK. But why did you delete the // FIXME UNICODE? By accident. Fixed and committed. Anyway, what is this 'FIXME UNICODE'? They are everywhere and nobody seems to be fixing them now. Bo

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Martin Vermeer
On Sun, Oct 14, 2007 at 10:09:41AM -0500, Bo Peng wrote: > Hi, Jurgen, > > I do not know the result of the lengthy InsetCharStyle discussion. Is > the attached patch still OK for the branch? (You approved it before.) > > Cheers, > Bo This seems like a good idea. Would this go for trunk as well?

Re: [PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Jürgen Spitzmüller
Bo Peng wrote: > Hi, Jurgen, > > I do not know the result of the lengthy InsetCharStyle discussion. Is > the attached patch still OK for the branch? (You approved it before.) It's OK. But why did you delete the // FIXME UNICODE? Jürgen

[PATCH] Making InsetCharStyle less prominent.

2007-10-14 Thread Bo Peng
Hi, Jurgen, I do not know the result of the lengthy InsetCharStyle discussion. Is the attached patch still OK for the branch? (You approved it before.) Cheers, Bo Index: src/insets/InsetCharStyle.h === --- src/insets/InsetCharStyle.h