Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-03-01 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : I tried it out, and as you suspected it crashes when doing latex export. The assertion I get is: [...] The relevant code is: bool need_par = pit->simpleTeXOnePar(buf, bparams, outerFont(pit - paragraphs.begin(), paragraphs),

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-03-01 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, Two files with this mail: Abdelrazak> RandomAccessList.h: renamed and cleaned up version of Abdelrazak> former it_vector.h ParagraphListRewrite.patch: updated Abdelrazak> with the above. Abdelrazak> I think th

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > /** > > - \todo This could be optimized a bit by rebuilding ItVector > > - instead of multiple deletion. > > + TODO: use std::remove_if and vector<>::erase, passing the > > You don't like '\todo'? Doxygen recognize it and generates

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Abdelrazak Younes
Angus Leeming a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: Just some little observations. Angus /// Copy constructor. RandomAccessList(RandomAccessList const & ext_list) { - for (const_iterator it = ext_list.begin(); -it != ext_list.en

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: Just some little observations. Angus /// Copy constructor. RandomAccessList(RandomAccessList const & ext_list) { - for (const_iterator it = ext_list.begin(); -it != ext_list.end(); ++it) +

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : An idea for testing: would i be possible to add temporarily to the at() method a test that the paragraph returned by the vector is the same as what would be obtained from the list (by std::advance, I guess)? This would help to make sure the vector and the list are alwa

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes a écrit : Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | Abdelrazak> Hello, Two files with this mail: | | Abdelrazak> RandomAccessList.h: renamed and cleaned up version of | Abdelrazak> former it_v

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, Two files with this mail: Abdelrazak> RandomAccessList.h: renamed and cleaned up version of Abdelrazak> former it_vector.h ParagraphListRewrite.patch: updated Abdelrazak> with the ab

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | Abdelrazak> Hello, Two files with this mail: | | Abdelrazak> RandomAccessList.h: renamed and cleaned up version of | Abdelrazak> former it_vector.h ParagraphListRewrite.patc

Re: [PATCH] Makes ParagraphList use RandomAccessList

2006-02-23 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, Two files with this mail: Abdelrazak> RandomAccessList.h: renamed and cleaned up version of Abdelrazak> former it_vector.h ParagraphListRewrite.patch: updated Abdelrazak> with the above. Abdelrazak> I think th

[PATCH] Makes ParagraphList use RandomAccessList

2006-02-21 Thread Abdelrazak Younes
Hello, Two files with this mail: RandomAccessList.h: renamed and cleaned up version of former it_vector.h ParagraphListRewrite.patch: updated with the above. I think that I took into account most if not all issues pointed by Lars and Angus. I have tested this pretty extensively. Abdel. Index