Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Richard Heck
Georg Baum wrote: Richard Heck wrote: The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. I don't have time to read the patch, but this goes definitely into the right direction. Since I was thinking to do the very

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Andre Poenitz
On Tue, Oct 23, 2007 at 04:26:31AM -0400, Richard Heck wrote: > [...] > >By the way Richard, I always forget to ask you but... could you please > >add some 'air' in your replies? Adding some empty lines eases the > >reading... > will do. > > *grin* I guess you'll need a second attempt ;-) Andr

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Georg Baum
Richard Heck wrote: > > The attached patch finishes this bit of work, left over from the > InsetCommand conversion. Comments welcome before I commit. I don't have time to read the patch, but this goes definitely into the right direction. Since I was thinking to do the very same thing some time a

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: Hum, if these are command strings you should not use to_utf8() but to_ascii(). ok. Note that the only difference is an assertion if the string is not ascii. You must therefore be sure that the user can never

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: >> Hum, if these are command strings you should not use to_utf8() but >> to_ascii(). > ok. Note that the only difference is an assertion if the string is not ascii. You must therefore be sure that the user can never make this assumption false. JMarc

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. Looks obviously good ;-) Next step is to remove the InsetCommandMailer... That's a different project rh --

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-23 Thread Richard Heck
Abdelrazak Younes wrote: Richard Heck wrote: Angus Leeming wrote: Richard Heck wrote: The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. This sort of change gives me a nice, warm, fuzzy feeling. It's obvious you'

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-22 Thread Abdelrazak Younes
Richard Heck wrote: Angus Leeming wrote: Richard Heck wrote: The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. This sort of change gives me a nice, warm, fuzzy feeling. It's obvious you've done something right wh

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-22 Thread Abdelrazak Younes
Richard Heck wrote: The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. Looks obviously good ;-) Next step is to remove the InsetCommandMailer... Abdel.

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-22 Thread Richard Heck
Angus Leeming wrote: Richard Heck wrote: The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. This sort of change gives me a nice, warm, fuzzy feeling. It's obvious you've done something right when you can remove so

Re: [PATCH] InsetInclude --> InsetCommand

2007-10-22 Thread Angus Leeming
Richard Heck wrote: > > The attached patch finishes this bit of work, left over from the > InsetCommand conversion. Comments welcome before I commit. > > Richard This sort of change gives me a nice, warm, fuzzy feeling. It's obvious you've done something right when you can remove so much code :

[PATCH] InsetInclude --> InsetCommand

2007-10-22 Thread Richard Heck
The attached patch finishes this bit of work, left over from the InsetCommand conversion. Comments welcome before I commit. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ ==