Re: [PATCH] Get rid of nasty popups

2001-09-18 Thread Juergen Spitzmueller
Am Dienstag, 18. September 2001 13:19 schrieb Angus Leeming: > > But params.hasDefaults() should be checked on every object-hit > > (it's changed by several objects). So it should be something like > > > > if (ob == any_object) { > > BufferParams params = lv_->buffer()->params; > > set

Re: [PATCH] Get rid of nasty popups

2001-09-18 Thread Angus Leeming
> But params.hasDefaults() should be checked on every object-hit (it's > changed by several objects). So it should be something like > > if (ob == any_object) { > BufferParams params = lv_->buffer()->params; > setEnabled(class_->button_reset_defaults, !params.hasClassDefaults()

Re: [PATCH] Get rid of nasty popups

2001-09-18 Thread Juergen Spitzmueller
Angus Leeming wrote: > > Is this correct? > > As JMarc says, looks Ok. Why not code it as: > > setEnabled(class_->button_reset_defaults, > !params.hasClassDefaults()); Yes, why not ;-) > > Furthermore I need to add something to FormDocument::input (I > > think) to enable "Reset" if I do so

Re: [PATCH] Get rid of nasty popups

2001-09-18 Thread Angus Leeming
On Tuesday 18 September 2001 09:32, Juergen Spitzmueller wrote: > I need some help. > I added to FormDocument::class_update > > if (params.hasClassDefaults()) > setEnabled(class_->button_reset_defaults, false); > else > setEnabled(class_->button_reset_defaults, true); > > Is this corr

Re: [PATCH] Get rid of nasty popups

2001-09-18 Thread Juergen Vigna
On 18-Sep-2001 John Levon wrote: > On Tue, Sep 18, 2001 at 08:08:52AM +0200, Juergen Spitzmueller wrote: > >> Yes, and I want to use them properly. So what I am supposed to do? Use >> /always/ 8-character-tabs, even if the rest of the "paragraph" seems to >> be intended with 4 characters? > >

Re: [PATCH] Get rid of nasty popups

2001-09-17 Thread John Levon
On Tue, Sep 18, 2001 at 08:08:52AM +0200, Juergen Spitzmueller wrote: > Yes, and I want to use them properly. So what I am supposed to do? Use > /always/ 8-character-tabs, even if the rest of the "paragraph" seems to > be intended with 4 characters? > > Thanks, > Jürgen no, keep to the style

Re: [PATCH] Get rid of nasty popups

2001-09-17 Thread Juergen Spitzmueller
Am Montag, 17. September 2001 18:06 schrieb John Levon: > On Mon, Sep 17, 2001 at 04:34:53PM +0200, Juergen Spitzmueller wrote: > > Sorry. I corrected this. There are some places where > > 4-character-indentation is used, though > > (FormDocument::class_update). I handled it the same there. > > al

Re: [PATCH] Get rid of nasty popups

2001-09-17 Thread John Levon
On Mon, Sep 17, 2001 at 04:34:53PM +0200, Juergen Spitzmueller wrote: > Sorry. I corrected this. There are some places where > 4-character-indentation is used, though (FormDocument::class_update). > I handled it the same there. all it needs is for someone who can commit to convert all the file

[PATCH] Get rid of nasty popups

2001-09-17 Thread Juergen Spitzmueller
As proposed by JMarc, I removed the annoying AskQuestion when changing the class in Layout -> Document. Instead I implemented a button "Reset" (to class defaults) and a checkbox "Auto Reset" (to class defaults). Furthermore I removed the irritating menu entry "Save as class defaults" in "Layou