On Mon, Oct 19, 2015 at 12:16:58PM +0200, Jean-Marc Lasgouttes wrote:
> Le 15/10/15 18:07, Richard Heck a écrit :
> >>The only changed behavior is that the CoordCache asserts when
> >>requiring a non existing cache entry, where insetDimension would
> >>return a dummy value. This can lead to some cr
Le 16/10/15 02:21, Scott Kostyshak a écrit :
On Thu, Oct 15, 2015 at 03:30:21PM +0200, Jean-Marc Lasgouttes wrote:
Scott, OK?
Yes.
It is in now.
JMarc
Le 15/10/15 18:07, Richard Heck a écrit :
The only changed behavior is that the CoordCache asserts when
requiring a non existing cache entry, where insetDimension would
return a dummy value. This can lead to some crashes, but I would say
that these are welcome in some cases.
Is there something
Le 16/10/15 02:21, Scott Kostyshak a écrit :
// FIXME (Abdel 23/09/2007): this is a bit messy
because of the
// elimination of Inset::dim_ cache. This coordOffset()
method needs
// to be rewritten in light of the new design
On Thu, Oct 15, 2015 at 03:30:21PM +0200, Jean-Marc Lasgouttes wrote:
> Scott, OK?
Yes.
> // FIXME (Abdel 23/09/2007): this is a bit messy
> because of the
> // elimination of Inset::dim_ cache. This coordOffset()
> method needs
>
On 10/15/2015 09:30 AM, Jean-Marc Lasgouttes wrote:
The following patch is a simple cleanup that was written before the
acceptation of the role of release master by Scott. It removes the
cache ParagraphMetrics:insetDimension, and relies on the already
existing BufferView::coordCache instead.
15 16:11:58 +0200
Subject: [PATCH] Get rid of ParagraphMetrics::insetDimension
We already have a CoordCache of insets dimensions. It is not necessary
to store the same information in two places.
Give a name to CoordCache tables types to improve code readability.
Remove ParagraphMetrics::sin
