Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > Helge Hafting wrote: >> Perhaps something like [tabular lost!] or >> [tabular paste currently unsupported], >> so the user won't wonder what went wrong. > > I really wouldn't paste error messages into a document. OK then. I thought we did something

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
Helge Hafting wrote: > Perhaps something like [tabular lost!] or > [tabular paste currently unsupported], > so the user won't wonder what went wrong. I really wouldn't paste error messages into a document. Jürgen

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Helge Hafting
Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: So I just let Cursor::selectionAsString return an empty docstring() with multi-cell selection. This breaks middle mouse pasting. Why not return something like "[tabular]" instead? Hm would you really want this? Perhaps something like [ta

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > So I just let Cursor::selectionAsString return an empty docstring() > > with multi-cell selection. This breaks middle mouse pasting. > > Why not return something like "[tabular]" instead? Hm would you really want this? Jürgen

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > So I just let Cursor::selectionAsString return an empty docstring() > with multi-cell selection. This breaks middle mouse pasting. Why not return something like "[tabular]" instead? JMarc

[patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
As you can reproduce with the attached test case, branch crashes if you select all the cells starting from the last cell ending up in the first. The reason is that Cursor::selectionAsString does not handle multiple cell selection and mixes the cursor positions in the starting and ending cells (r

Re: [PATCH] Fix tabular crash

2006-10-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, I propose to put this patch in order to make tables Abdelrazak> usable again. I ha

Re: [PATCH] Fix tabular crash

2006-10-19 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdelrazak> Hello, I propose to put this patch in order to make tables Abdelrazak> usable again. I have been using th

Re: [PATCH] Fix tabular crash

2006-10-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, I propose to put this patch in order to make tables Abdelrazak> usable again. I have been using this patch for some time Abdelrazak> and I didn't see any obvious side effect for now. Do

Re: [PATCH] Fix tabular crash

2006-10-19 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, I propose to put this patch in order to make tables Abdelrazak> usable again. I have been using this patch for some time Abdelrazak> and I didn't see any obvious side effect for now. Does the crash happen only

[PATCH] Fix tabular crash

2006-10-19 Thread Abdelrazak Younes
Hello, I propose to put this patch in order to make tables usable again. I have been using this patch for some time and I didn't see any obvious side effect for now. Objection? Of course, this is not the right fix but I spend hours debugging through this code without success. So unless some

[patch] fix tabular crash

2004-02-20 Thread Andre Poenitz
This fixes a crash in InsetTabular when moving up/down. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...) ? 1.diff ? 2.diff ? 3.diff ? fullredraw.diff ? par-row.diff ? qfont_loade