Re: [PATCH] Fix compiler warning

2006-11-29 Thread Andre Poenitz
On Sun, Nov 26, 2006 at 08:04:19PM +0100, Georg Baum wrote: > Even if you consider the multiple hfill case, e.g. you have to draw 3 > hfills in a space of 37 pixels you somehow have to distribute this space to > the 3 hfills, e.g. the first and second one are 12 pixels wide, and the > third is 1

Re: [PATCH] Fix compiler warning

2006-11-28 Thread Andre Poenitz
On Sat, Nov 25, 2006 at 01:45:43PM +0100, Michael Gerz wrote: > Georg Baum wrote: > >No, it does not fix a conversion, it suppresses a compiler warning. I > >don't understand why x_ is of type double at all. Why not int? > > I guess there are cases (like with multiple hfills), where x_ would be

Re: [PATCH] Fix compiler warning

2006-11-28 Thread Andre Poenitz
On Sat, Nov 25, 2006 at 01:44:20PM +0100, Abdelrazak Younes wrote: > Georg Baum wrote: > >Am Freitag, 24. November 2006 23:20 schrieb Michael Gerz: > >>Hi, > >> > >>this patch fixes a double-to-int conversion. (already committed) > > > >No, it does not fix a conversion, it suppresses a compiler war

Re: [PATCH] Fix compiler warning

2006-11-28 Thread Andre Poenitz
On Sat, Nov 25, 2006 at 02:16:41PM +0100, Abdelrazak Younes wrote: > Michael Gerz wrote: > >Georg Baum wrote: > > > >>No, it does not fix a conversion, it suppresses a compiler warning. I > >>don't understand why x_ is of type double at all. Why not int? > >> > >> > >I guess there are cases (like

Re: [PATCH] Fix compiler warning

2006-11-26 Thread Georg Baum
Am Samstag, 25. November 2006 13:45 schrieb Michael Gerz: > Georg Baum wrote: > > >No, it does not fix a conversion, it suppresses a compiler warning. I don't > >understand why x_ is of type double at all. Why not int? > > > > > I guess there are cases (like with multiple hfills), where x_ wou

Re: [PATCH] Fix compiler warning

2006-11-25 Thread Abdelrazak Younes
Michael Gerz wrote: Georg Baum wrote: No, it does not fix a conversion, it suppresses a compiler warning. I don't understand why x_ is of type double at all. Why not int? I guess there are cases (like with multiple hfills), where x_ would be incremented by a fraction of a pixel. If this hap

Re: [PATCH] Fix compiler warning

2006-11-25 Thread Michael Gerz
Georg Baum wrote: No, it does not fix a conversion, it suppresses a compiler warning. I don't understand why x_ is of type double at all. Why not int? I guess there are cases (like with multiple hfills), where x_ would be incremented by a fraction of a pixel. If this happens several times an

Re: [PATCH] Fix compiler warning

2006-11-25 Thread Abdelrazak Younes
Georg Baum wrote: Am Freitag, 24. November 2006 23:20 schrieb Michael Gerz: Hi, this patch fixes a double-to-int conversion. (already committed) No, it does not fix a conversion, it suppresses a compiler warning. I don't understand why x_ is of type double at all. Why not int? Indeed, ther

Re: [PATCH] Fix compiler warning

2006-11-25 Thread Georg Baum
Am Freitag, 24. November 2006 23:20 schrieb Michael Gerz: > Hi, > > this patch fixes a double-to-int conversion. (already committed) No, it does not fix a conversion, it suppresses a compiler warning. I don't understand why x_ is of type double at all. Why not int? Georg

[PATCH] Fix compiler warning

2006-11-24 Thread Michael Gerz
Hi, this patch fixes a double-to-int conversion. (already committed) Michael Index: rowpainter.C === --- rowpainter.C (Revision 16028) +++ rowpainter.C (Arbeitskopie) @@ -48,7 +48,6 @@ using std::endl; using std::max; -using std