Re: [PATCH] Fix all scrolling bugs

2006-08-20 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, Aug 17, 2006 at 12:20:20AM +0200, Jean-Marc Lasgouttes wrote: | > The only bug I saw is that when one loads a file through command line | > in gtk, the screen is black until one clicks. A missing update, I | > guess. | > | > On thing that may in

Re: [PATCH] Fix all scrolling bugs

2006-08-20 Thread Andre Poenitz
On Thu, Aug 17, 2006 at 12:20:20AM +0200, Jean-Marc Lasgouttes wrote: > The only bug I saw is that when one loads a file through command line > in gtk, the screen is black until one clicks. A missing update, I > guess. > > On thing that may interest you is that, while the qt3 frontend is > sluggis

Re: [PATCH] Fix all scrolling bugs

2006-08-17 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Well, gtk did not have all of the lovin' and great optimization that gtk ha

Re: [PATCH] Fix all scrolling bugs

2006-08-17 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Well, gtk did not have all of the lovin' and great optimization that gtk had... Abdelrazak> By, the

Re: [PATCH] Fix all scrolling bugs

2006-08-17 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Well, gtk did not have all of the lovin' and great optimization that gtk had... Abdelrazak> By, the way...

Re: [PATCH] Fix all scrolling bugs

2006-08-17 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Well, gtk did not have all of the lovin' and great optimization that gtk had... By, the way... most of the optimisation I did are common to all frontends so gtk should also benefit from that. Abd

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Well, gtk did not have all of the lovin' and great optimization >> that gtk had... Abdelrazak> I am not sure qt3 scrolling is done how it should be. I am also interested in this to see what low hanging fruits I may find for

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: On thing that may interest you is that, while the qt3 frontend is Abdelrazak>^ Abdelrazak> You still didn't even try to compile the qt4 frontend? I

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Well, gtk did not have all of the lovin' and great Jean-Marc> optimization that gtk had... ^^^--qt4 Grr. JMarc

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> On thing that may interest you is that, while the qt3 frontend is Abdelrazak>^ Abdelrazak> You still didn't even try to compile the qt4 frontend? I'd Abdelrazak> call that

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hi all, This patch should hopefully all scrolling issues. Abdelrazak> As an added bonus, mouse scrolling should be faster due to Abdelrazak> a deleted call to BufferView::update() that was not

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hi all, This patch should hopefully all scrolling issues. Abdelrazak> As an added bonus, mouse scrolling should be faster due to Abdelrazak> a deleted call to BufferView::update() that was not Abdelrazak> usefull (the

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I am going to commit this soon unless there's some style Abdelrazak> objection. Abdelraza

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes wrote: >>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Abdelrazak> I am going to commit this soon unless there's some style Abdelrazak> objection. >> Abdelrazak> adjustCurs

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I am going to commit this soon unless there's some style Abdelrazak> objection. Abdelrazak> adjustCursorWithScrollbar(): new method. Nitpick: this one does not sound good. syncCursorWithScrol

Re: [PATCH] Fix all scrolling bugs

2006-08-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I am going to commit this soon unless there's some style Abdelrazak> objection. Abdelrazak> adjustCursorWithScrollbar(): new method. Nitpick: this one does not sound good. syncCursorWithScrollbar()? setCursorFromScro

[PATCH] Fix all scrolling bugs

2006-08-16 Thread Abdelrazak Younes
Hi all, This patch should hopefully all scrolling issues. As an added bonus, mouse scrolling should be faster due to a deleted call to BufferView::update() that was not usefull (the important call to updateMetrics() is done in WorkArea()). I am going to commit this soon unless there's some s