> I also don't like the hijacking of updateLabels(). So, if you go for a
> signal solution, then emit this signal when the embedding status is
> effectively changed and not every time you update the labels.
This is what I will have to do later.
The patch is in for now so that I can finish the emb
Andre Poenitz wrote:
On Mon, Sep 03, 2007 at 08:11:29PM -0500, Bo Peng wrote:
I need a good signal handling mechanism to update the embedding
dialog. Because addition/removal of embedding files only happens to
certain insets, it should be easier than the Toc dialog. This patch
emits the embeddin
On Mon, Sep 03, 2007 at 08:11:29PM -0500, Bo Peng wrote:
> > The only comment I have is that during ordinary development time no 'two
> > OKs' are formally needed.
>
> The problem here is that I have less confidence in this patch. It
> looks more like a temporary fix than a formal solution.
>
> >
> The only comment I have is that during ordinary development time no 'two
> OKs' are formally needed.
The problem here is that I have less confidence in this patch. It
looks more like a temporary fix than a formal solution.
> has a tendency to shorten after committing lots of uncontroversial
> s
On Mon, Sep 03, 2007 at 04:17:15PM -0500, Bo Peng wrote:
> > Please comment and test. Because this patch changes core lyx
> > functionality, I will wait for two OKs to proceed.
>
> No comment?
The only comment I have is that during ordinary development time no 'two
OKs' are formally needed. If yo
> Please comment and test. Because this patch changes core lyx
> functionality, I will wait for two OKs to proceed.
No comment?
There is an obvious problem with this patch in that embeddingChanged
is checked in updateLabels, along with structureChanged. That is to
say, embedding dialog is updated
Dear all,
Attached please find the fourth embedding patch that enables automatic
update of the embedding dialog with the addition/removal of insets
with embedded files, and open/close of buffer. The patch mimics the
way TOC is updated, I suspect that cbuf.embeddedFiles().update() can
be very expe
