Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Bo Peng
> I mean 'make it look like the rest of LyX source'. > > And yes, using ANSI C instead of K&R is a step in the right direction. Doing it... to make g++ understand the code. Bo

Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Andre Poenitz
On Tue, Aug 21, 2007 at 02:06:14PM -0500, Bo Peng wrote: > > Do that. But also adjust code style. > > You mean changing 'func(a) int a' to 'func(int a)'? I mean 'make it look like the rest of LyX source'. And yes, using ANSI C instead of K&R is a step in the right direction. Andre'

Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Bo Peng
> Do that. But also adjust code style. You mean changing 'func(a) int a' to 'func(int a)'? Bo

Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Andre Poenitz
On Tue, Aug 21, 2007 at 08:27:39AM -0500, Bo Peng wrote: > > I am also wondering if we can add zip/contrib/minizip > > (four source files) to lyx/svn to make our life a bit easier. > > How about adding these four minizip files to src/support/minizip? Do that. But also adjust code style. Andre'

Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Bo Peng
> That seems the logical thing to do. Done. Bo

Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Abdelrazak Younes
Bo Peng wrote: I am also wondering if we can add zip/contrib/minizip (four source files) to lyx/svn to make our life a bit easier. How about adding these four minizip files to src/support/minizip? That seems the logical thing to do. Abdel.

Re: [PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-21 Thread Bo Peng
> I am also wondering if we can add zip/contrib/minizip > (four source files) to lyx/svn to make our life a bit easier. How about adding these four minizip files to src/support/minizip? Bo

[PATCH] Embedding feature patch 1: add zipFiles and unzipToDir to support.

2007-08-20 Thread Bo Peng
This is the first of the embedding patch series. It adds functions zipFiles and unzipToDir to src/support/filetools.[h|cpp]. This allows the handling of zipped .lyx file. src/support/lyxlib.[h|cpp]: add function makedir that recursively create a directory. Function adapted from zlib/contrib/mi